Changes between Initial Version and Version 1 of Ticket #10116, comment 8


Ignore:
Timestamp:
Nov 21, 2017, 6:11:31 PM (7 years ago)
Author:
csnover

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #10116, comment 8

    initial v1  
    1515It is frustrating to me that this was known UB and compilers actively were warning about it and instead of eliminating the UB `42` was added to defeat the heuristic of the compiler.
    1616
    17 This code happens to also crash Clang’s UndefinedBehaviorSanitizer code, which can’t deal with someone trying to get the offset of a member in a class with a vtable like this.
     17This code happens to also crash Clang 5’s UndefinedBehaviorSanitizer code, which can’t deal with someone trying to get the offset of a member in a class with a vtable like this.
    1818
    1919So in conclusion, this save code needs to be fixed to be C++-compliant, and I don’t know enough about this engine right now to know how to do that successfully.