SCUMM: MI 1+2 (Ultimate Talkie Patch) - preferences keyboard controls no longer function

[SirFritz]

Version ScummVM 2.0.0
Windows 10 x64 1803

In either SoMI or MI2 using their respective ultimate talkie patch, pressing one of the custom keyboard controls to change preferences (such as CTRL-p to change spiffy graphics mode or CTRL-a to change narrator mode) has no effect. The change isn't made and the on-screen text displaying your current setting doesn't show. It works fine in version 1.9.0 and earlier using the same game files and scummvm.ini file. It also doesn't work in 2.1.0 dev build from july 24.

[JiFish]

This doesn't just effect Ultimate Talkie. The famous "CTRL-W" to win the game Easter Egg also doesn't function.

I suggest this bug be renamed "SCUMM: MI 1+2 - In-engine keyboard controls no longer function" (or something to that effect)

[sev-]

This would be nice to get fixed before the release.

[orgads]

It looks like Ctrl is not passed to the game. If I press Ctrl-P with 1.9, it changes spiffy mode, but with later versions it acts as P (chooses Pick Up action). Same for Ctrl-O which has no effect with 1.9, but with 2.2 it chooses Open.

[orgads]

I just built 1.9.0 from source (on mingw), and the bug still reproduces. It works as expected with the binary distribution from ​https://downloads.scummvm.org/frs/scummvm/1.9.0

That's very strange. Maybe it's platform dependent?

[orgads]

​https://github.com/scummvm/scummvm/pull/3324

[sev-]

The pull request has been merged. The issue is fixed.