Changes between Version 1 and Version 2 of Ticket #10748, comment 12


Ignore:
Timestamp:
Nov 26, 2018, 4:08:42 AM (6 years ago)
Author:
Vhati

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #10748, comment 12

    v1 v2  
    4141// low resolution coordinates
    4242
    43 ...
     43# ...
    4444
    4545if (_mirrorX != celObj._mirrorX && _celInfo.type == kCelTypePic) {
    4646        Common::Rect temp(_insetRect);
    4747
    48 ...
     48        if (!scaleX.isOne()) {
     49                mulinc(temp, scaleX, Ratio());
     50                temp.right -= 1;
     51        }
     52
     53        CelObjPic *celObjPic = dynamic_cast<CelObjPic *>(_celObj.get());
     54        if (celObjPic == nullptr) {
     55                error("Expected a CelObjPic");
     56        }
     57        temp.translate(celObjPic->_relativePosition.x - (originX * scaleX).toInt(), celObjPic->_relativePosition.y - (celObj._origin.y * scaleY).toInt());
    4958
    5059        // TODO: This is weird.
    … …  
    5665}}}
    5766
    58 That comment could be interesting.
     67That TODO comment could be interesting.
    5968\\
    6069\\
    … …  
    7079If you take the screen width, subtract the width of a full screen image, and subtract 1, you get -1.
    7180
     81scaleX.isOne() is true, so the little IF block that decrements temp.right is not happening.
     82\\
     83\\
    7284After some tinkering with forced values of deltaX exclusively for that big screenItem, I realized ALL these items were elements of the Pic. The small ones had been carved out, leaving black silhouettes in the big one. Stuff hero could walk behind. Priority.
    7385