"Trim FM-Towns games to 200 pixels height" option doesn't appear in Loom FM-Towns

[LukasThyWalls]

The option "Trim FM-Towns games to 200 pixels height" in Game tab for FM-Towns games doesn't appear in all of them Loom FM-Towns.

I have installed Zak FM-Towns (Directly from GOG version) with and without a Spanish fan patch, and the only version with that option is the one with the Spanish fan translation, not the one with the vanilla files from the GOG version.
Also i tested a Loom FM-Towns with a Spanish fan translation, and also doesn't show the option.

The setting works for the one it shows it.

In ScummVM.ini file, the only games entry with the setting "trim_fmtowns_to_200_pixels" is the one that is showing it in the GUI.

[eriktorbjorn]

I can't reproduce this bug. The "Trim FM-TOWNS games to 200 pixels height" option shows up fine for me with the English GOG FM Towns version.

The only thing I can think of is if the English version was added to ScummVM so long ago that some setting in the file that it expects to be there isn't. If so, it should be visible if you re-add the game.

The conditions for when the option is added are:

• The Platform setting has to be FM-TOWNS.
• The game's detection entry has to have the GUIO_TRIM_FMTOWNS_TO_200_PIXELS flag.

The only SCUMM FM-TOWNS game I can find that doesn't have this flag is Loom.

[LukasThyWalls]

eriktorbjorn is correct.

Using 2.6.0git4526-g1d1a12b3aca, i remove and added again zak-fm in both english and spanish (fan translation) and now in both appears the setting.
Is strange because when i added them before (it's been a while) it was in a consecutive way: copying the files from GOG, copying the folder twice, applying the spanish patch to one, and adding both to ScummVM at the same time. Maybe i'm remembering wrong, but anyway, the settings appears now in both.

But it's true, the Loom FM-Towns doesn't add the option. As seen in ​https://github.com/scummvm/scummvm/blob/master/engines/scumm/detection_tables.h#L181, the detection lacks the GUIO_TRIM_FMTOWNS_TO_200_PIXELS flag.

If it's intended that flag can be used in Loom FM-Towns for any reason yet, this bug can be closed. I edited the bug to reflect the issue now it's about Loom FM-Towns only.

Thanks.