Changes between Initial Version and Version 1 of Ticket #13841


Ignore:
Timestamp:
Sep 12, 2022, 7:13:14 AM (2 years ago)
Author:
macca8
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13841 – Description

    initial v1  
    55This latest switch has revealed a nasty bug which sets a save file’s _saveType property value to kSaveTypeAutosave, regardless of the file’s true type. This allows an autosave to automatically overwrite any regular save that may be stored in the autosave slot of affected engines (e.g. ZGI).
    66
    7 This appears to originate from an expectation that the saveType test wouldn’t be reinstated to the autosave test.
     7This appears to originate from an expectation that the saveType test wouldn’t be reinstated to the autosave test (refer #13842 for why this test is required).
    88
    99It’s due to an alternative method introduced while the saveType test was removed from autosave testing, which sets the _saveType value based on the slot in which the file is stored. Apparently, this was to allow isAutosave() to replace calls of type "slot == autosave slot", ensuring it would always return true if a file was found in the autosave slot (refer [https://github.com/scummvm/scummvm/pull/3261  PR3261], and in particular [https://github.com/scummvm/scummvm/commit/7adad5aaf5831dc5adcee140f38aacc4a5db2518 7adad5aa] for the original changes specific to this issue).