Changes between Version 2 and Version 3 of Ticket #13841


Ignore:
Timestamp:
Oct 5, 2022, 5:09:38 AM (2 years ago)
Author:
macca8
Comment:

Since there's been no response, I'm changing the component to something more generic, in the hope of stimulating some interest, and avoiding this issue finding its way into the 2.6.1 release (the same applies to #13842).

Not sure which is the correct component here. It's really a global issue affecting most engines, but there's no general "Engines" component listed (perhaps that should be added to the list, similar to Ports?), so I've settled on Other, rather than Common (which was used with ​9b05c206, which originally exposed this issue).

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #13841

    • Property Component Common → --Other--
    • Property Summary ENGINES: Setting a file's _saveType value by where it’s stored can cause a regular save to be overwritten. → ENGINES: AUTOSAVE: Setting a file's _saveType value by where it’s stored can cause a regular save to be overwritten.

  • Ticket #13841 – Description

    v2 v3  
    1515Hopefully, most users will have removed any regular saves from their more popular games, via the in-game warning dialog, before this latest switch was effected.
    1616
    17 However, as a matter of urgency, the changes in engines/savestate.cpp & engines/metaengine.cpp should be reverted or adjusted as appropriate, to remove any further risk to users.
     17However, as a matter of urgency, the changes in engines/savestate.cpp & engines/metaengine.cpp should be reverted or adjusted as appropriate, to remove any further risk to users.
     18
     19The following suggestions simply revert the saveType test to its previous values & behaviour before PR3261, and include any subsequent changes in the same blocks of code since PR3261.
    1820
    1921Proposed changes for consideration to complement removal of _saveType initialization from initSaveType() function (including renaming) in engines/savestate.cpp:
    … …  
    106108}}}
    107109
    108 Individual engines targeted in [https://github.com/scummvm/scummvm/commit/7adad5aaf5831dc5adcee140f38aacc4a5db2518 7adad5aa] will need to be reviewed for potential changes, though most only involved the removal of calls setting the writeProtected & Deletable flags (which can be ignored).
     110Individual engines targeted in [https://github.com/scummvm/scummvm/commit/7adad5aaf5831dc5adcee140f38aacc4a5db2518 7adad5aa] will need to be reviewed for potential changes (in particular Cine & SCI), though most only involved the removal of calls setting the writeProtected & Deletable flags (which can be ignored).