Changes between Initial Version and Version 1 of Ticket #14470, comment 5


Ignore:
Timestamp:
May 21, 2023, 12:45:24 PM (16 months ago)
Author:
athrxx

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #14470, comment 5

    initial v1  
    1 If you look at the code, you can see that the existing version will make the call to the callback function only for certain buffer lenghts (which are passed as an argument to the function from the common mixer coder). Only the incrementation of _mixpos will ensure that the callback is invoked ad proper intervals. My guess is that the mixer PR changed the buffer sizes, so that the bug is no longer disguised. But I am not the author of that mod player, so what do I know... :-)
     1If you look at the code, you can see that the existing version will make the call to the callback function only for certain buffer lenghts (which are passed as an argument to the function from the common mixer code). Only the incrementation of _mixpos will ensure that the callback is invoked at proper intervals. My guess is that the mixer PR changed the buffer sizes, so that the bug is no longer disguised. But I am not the author of that mod player, so what do I know... :-)
    22