SCUMM: MANIAC (Amiga): Continuous looping sound when choosing first character

[gabberhead]

right at the beginning, when choosing a first character, the sound continous loops and dont stop. testet with the amiga version and the daily builts from yesterday and today. perhaps other versions are affected as well.
with the stable 2.7.0 version, it works like it should.

[AndywinXp]

Apparently, like Rootfather found out, this might be caused by a regression from one of these two commits:

​https://github.com/scummvm/scummvm/commit/0f045a4ce4dbfe4e6a22c28a75127ae8af8e1b4c
​https://github.com/scummvm/scummvm/commit/5ca776639f0ed18cc250b14edd5bf5ee95840bb0

[gabberhead]

i tested the german dos v2 version. the dos version dont have this problem.

[athrxx]

It seems to be a problem in the mod player (player_mod.cpp, line 180). That player is used in the Amiga version only.

[AndywinXp]

Changing it like suggested (_mixpos += len;) fixes the issue, but I wonder why it worked fine before and if there's a bit more to it

[athrxx]

If you look at the code, you can see that the existing version will make the call to the callback function only for certain buffer lenghts (which are passed as an argument to the function from the common mixer coder). Only the incrementation of _mixpos will ensure that the callback is invoked ad proper intervals. My guess is that the mixer PR changed the buffer sizes, so that the bug is no longer disguised. But I am not the author of that mod player, so what do I know... :-)

[AndywinXp]

Oof, that explains it, thanks :-)

[AndywinXp]

Could you please confirm that the issue is now fixed with the current daily?

[gabberhead]

yes. it is fixed :)

[AndywinXp]

Thanks :) Closing!