Changes between Initial Version and Version 1 of Ticket #15025, comment 2


Ignore:
Timestamp:
Apr 18, 2024, 8:10:58 AM (7 months ago)
Author:
eriktorbjorn

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #15025, comment 2

    initial v1  
    22
    33{{{
    4              
    5              
    6   1 1 1 1 3 
    7     3 3 3 1 3
    8 2 1 1 1 1 1 3
    9 1 3 3 3 3 1 3
    10 2 1 1 1 1 1 3
    11   3 3 3 3 3 3
     4                    
     5                    
     6    1  1  1  1  3  
     7       3  3  3  1 3
     8 2  1  1  1  1  1 3
     9 1  3  3  3  3  1 3
     10 2  1  1  1  1  1 3
     11    3  3  3  3  3 3
    1212}}}
    1313
    … …  
    2727I.e. colors 2 and 3 are both mapped to black. But color 2 should probably be mapped to something else?
    2828
    29 `_charsetColorMap[1]` gets set by `CharsetRendererV7::drawCharV7()` but what about the rest of it? It does get initialized by the `SO_CHARSET_COLOR` of `ScummEngine_v6::o6_cursorCommand()`, though. Everything in `_charsetColorMap[]` gets set to zero, except for entries 1 and 2 which are set to 15 and 7 respectively. Well, we did get 15 but what happened to the 7?
     29`_charsetColorMap[1]` gets set by `CharsetRendererV7::drawCharV7()` but what about the rest of it? It does get initialized by the `SO_CHARSET_COLOR` of `ScummEngine_v6::o6_cursorCommand()`. Everything in `_charsetColorMap[]` gets set to zero, except for entries 1 and 2 which are set to 15 and 7 respectively. Well, we did get 15 earlier but what happened to the 7?
    3030
    31 It seems it gets zeroed out in `ScummEngine::initCharset()`, by copying `_charsetData[charsetno]` into it. There are a number of places where this can happen, but that's the one that gets triggered here. If I just remove that `memcpy()` the character seems to be rendered correctly.
     31It seems it gets zeroed out in `ScummEngine::initCharset()` by copying `_charsetData[charsetno]` into it. There are a number of places where this can happen, but that's the one that gets triggered here. If I just remove that `memcpy()` the character seems to be rendered correctly.
    3232
    3333Of course this is just an observation. I'm not saying that it is the correct fix!