TITANIC: Star locking/unlocking via green lights, differences

[dafioram]

In the original game you could use the green buttons to lock and unlock from stars. You could lock onto a star when the green light is flashing and you click it.

1. In scummvm you can lock on, but not unlock.
2. You can keep locking on until you hit the D key to unlock a star and then you can no longer use the green buttons to lock on.

Since the L and D keys work for locking/unlocking one fix would be to simulate an L click when the player clicks on the flashing green light and to simulate a D click when the user clicks the right most solid green light.

[dafioram]

Fixed by dreammaster in 74c401c926f1c38d74c09b290e62de900e741ee6 (Sep 9).

[dreammaster]

Actually, there was a little bit extra problem I was still working on, with _isInLockingProcess not being reset if you kept the cursor out of the starfield area. It resulted in unlocking not working if you toggled between locked and unlocked multiple times. I think I've fixed in the latest commit by resetting it in the removeMarker method.

[dafioram]

As a part of the implementation of the fix for #10170, I wasn't sure exactly when the code was done executing a lock, but for sure it was done when the user tried to move the view with their mouse in CStarCamera::setViewportAngle. So that is why you are seeing the behavior of the unlocking/locking not working until there is movement in the screen area.

So if where you have inserted the unlocking flag, CStarCamera::removeMover(), is sooner than the unlocking in the beginning of CStarCamera::setViewportAngle, but after the locking process has concluded then the unlock flag being set in StarCamera::setViewportAngle can be removed.