Opened 7 years ago
Closed 4 years ago
#10304 closed defect (fixed)
SCI: QFG3: Night palette no longer loads after Storyteller event
| Reported by: | EricOakford | Owned by: | wjp |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | ||
| Cc: | Game: | Quest for Glory 3 |
Description
Scummvm: 1.10.0git5264-g9030b09ecc
Game: Quest for Glory III 1.1
OS: Win10-64
After the storyteller tells his story at nightfall, the Hero automatically returns to the guest hut to sleep for the night. The following night, however, the game never loads the palette for nighttime (though the game otherwise treats it as though it is night), making it appear like it's still daytime. This creates odd quirks such as the moon being present in broad daylight at the Pool of Peace or the Hero's room at the Welcome Inn.
I enclosed a savegame right before the storyteller (note that here, the night palette is working properly) This glitch doesn't happen in the original interpreter.
Attachments (3)
Change History (6)
by , 7 years ago
by , 7 years ago
| Attachment: | scummvm00000.png added |
|---|
While this appears to be daytime, the moon is in the sky.
comment:1 by , 7 years ago
While sleeping/waking up, _palVaryPaused gets set to 1 and stays stuck there because the palvary Resume call is ignored since _palVaryResourceId == -1 at the time (due to the palVaryProcess call inside kernelPalVaryReverse).
Possibly related to 3e6fb233ac33d74e7045fc8e172e4ac86f5f682c. Need to investigate further.
comment:2 by , 7 years ago
Two possible workarounds/fixes at https://github.com/wjp/scummvm/commit/af8e014b712ae6490e76949d4bb71890fd8b8ecb and https://github.com/wjp/scummvm/commit/15045d59fd33bba5da62c62ba96853f107ff5f37 . Needs discussing.
comment:3 by , 4 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Looks like this was fixed three years ago.
https://github.com/scummvm/scummvm/commit/65861bb914a3174a2922ba8f9c6435db0cc70f35 was committed in April 2018 after a thorough discussion in https://github.com/scummvm/scummvm/pull/1075
I verified the fix with the attached save by going to the storyteller, automatically going to sleep, and then waiting for the next night. The night palette shift occurred correctly.
I'm a little concerned that the readme for AshLancer's excellent QFG3 fan patch says this is still a bug in ScummVM, but from the commit history and context I can't tell if that was written before or after this was merged into master: https://github.com/AshLancer/QFG3-Fan-Patch/blob/master/Readme%201.3A.md
Savegame just before the storyteller event