Opened 7 years ago

Closed 5 years ago

#10368 closed defect (fixed)

WIN32: WinSparkle doesn't terminate ScummVM.exe before launching the installer

Reported by: rootfather Owned by: sluicebox
Priority: normal Component: Port: Win32
Version: Keywords: updater
Cc: Game:

Description

I updated from 1.9.0.2 to 2.0.0 using the WinSparkle updater.

I noticed that after downloading the updated installer and clicking the final "Install Update" button, WinSparkle launches the new installer without terminating the ScummVM process before. This will cause the Inno installer dropping an error message and a request to close the application. While this can be done in the Inno installer itself, this might be just a bit confusing to the end user and not a real problem.

Maybe the WinSparkle implementation can be tweaked to close ScummVM.exe before launching the Inno installer instead of relying on the Inno feature that detects files that are in use.

Change History (5)

comment:1 by digitall, 6 years ago

Component: --Unset-- → Ports

comment:2 by digitall, 6 years ago

Component: Ports → Port: Win32

comment:3 by henke37, 5 years ago

Keywords: updater added

comment:4 by sev-, 5 years ago

In f74f8e3c:

WIN32: Exit when WinSparkle runs installer

Trac #10368

comment:5 by sluicebox, 5 years ago

Owner: set to sluicebox
Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.