LSL6 Hi-res: Oil lamp with spigot freezes the game

[Hysler]

ScummVM version: 2.0.0
Platform: Windows 64
Game: LSL6 Hi-res/DOS/English

When you use the oil lamp on the spigot to collect cellulite, the game freezes before the animation can finish.

[Hysler]

Use oil lamp on spigot next to Larry to replicate freeze.

[bluegr]

This is a bug in the original game, and has been fixed by an official patch by Sierra. You can download the patch (LSL6PAT) here:
​http://www.sierrahelp.com/Patches-Updates/Patches-Updates-Games/LeisureSuitLarryUpdates.html

You need to copy all the MSG, HEP and SCR files in the directory where you installed your game.

Closing as won't fix, as there is an official patch for this bug

[sluicebox]

There is no bug here, the reporter didn't copy the PATCHES directory from their CD. They were bound to have many problems.

The spigot bug is in lo-res versions, it was fixed in hi-res. There's not even a patch for the lo-res version, Sierra just offers a saved game from after the scene. The fix is contained in the PATCHES directory on the hi-res CD, along with many other patch files.

You can tell that the reporter is missing PATCHES because ScummVM won't load the attached saved game. Script 0 is the wrong size. There's patch files for script 0 in PATCHES but the saved game is for the unpatched size in RESOURCE.000 which should never be used.

I'll add the lo-res spigot bug to the queue =)

[sluicebox]

I dug into this further.

The original problem was with some CD-ROM distributions that included LSL6 Hi-Res. After you installed it, the patchDir line in RESOURCE.WIN didn't include the correct path to the PATCHES directory on the CD-ROM. If the CD-ROM drive was D then it would use D:\PATCHES instead of the correct D:\HIRES\PATCHES. This meant that the broken version of the lamp script got used, along with a lot of other older resources that weren't meant to be used.

Sierra's "patch" was a save game file and a text file. The save game was made with the buggy resources as a workaround; it takes you just past the buggy lamp script, but you'll still be playing with the older resources. The text file includes instructions for properly fixing the bug by editing RESOURCE.WIN to add the correct path, which would probably break any existing save games.

ScummVM is unaffected by all of this since it doesn't use RESOURCE.WIN and just uses the resource files you give it. Dang, no script patch to write here! =)

Of course, if you somehow misplace your PATCHES directory, you'll get the same symptoms as players did in 1997, which is what happened here.

[sluicebox]

Oh fine, I patched it: ​https://github.com/scummvm/scummvm/commit/0d4771c83870f49803ae002c71d1c08785cf8440

This came up again in the forums recently: ​https://forums.scummvm.org/viewtopic.php?t=16505

I don't know exactly what it is about this one that keeps leading to people missing the PATCHES directory, but by time they discover it they're stuck, and adding the missing files invalidates saves so they have to start over.

Because the script bug is so simple and only requires changing one byte, patching seemed a better alternative than having this be an ongoing thing.