Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#10730 closed defect (fixed)

SCI: LB2: Bugs With Meat are buggy

Reported by: sluicebox Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords: original has-pull-request
Cc: Game: Laura Bow 2: The Dagger of Amon-Ra

Description

The bugs with meat in the basement hallway lockup the game if they appear while opening the door to Wolfe's office. This lockup also occurs using Sierra's interpreter in all versions of the game.

Another player hit the same lockup during their review: https://advgamer.blogspot.com/2017/10/the-dagger-of-amon-ra-won.html

The bugs show up carrying meat after 5 seconds in the room. Opening the door to Wolfe's office and walking through the entrance takes a few seconds. If the bugs' script starts while the door is opening then you will walk through the entrance but never regain input control in Wolfe's office. If the script starts after the door has opened then you will stop walking and be left with a broken door until you re-enter the room. Similar problems occur with the other door.

I've written a script patch that should take care of all of the problems.

Attached are saves of floppy 1.0 and cd in Wolfe's office. To reproduce (may take a few tries):

  1. Exit south to the hallway
  2. Wait three seconds after the door closes
  3. Open the door you came through


If you make it through to Wolfe's office with no problems then try again but wait a little longer. If the bugs show up before the door opens, try again and wait a little less. If the bugs make it all the way off the southern end of the screen then they won't come back and you'll have to restore.

The debugger makes it easier to test this. set a breakpoint with "bpx bugsWithMeat::cue" on cd or "bpx bugsWithMeat::<noname145>" on floppy to see when the script gets run. This helps you time opening the door to trigger the lockup and test the fix.

Attachments (2)

laurabow2.016 (43.8 KB ) - added by sluicebox 6 years ago.
laurabow2-cd.018 (42.7 KB ) - added by sluicebox 6 years ago.

Download all attachments as: .zip

Change History (8)

by sluicebox, 6 years ago

Attachment: laurabow2.016 added

by sluicebox, 6 years ago

Attachment: laurabow2-cd.018 added

comment:1 by m-kiewitz, 6 years ago

I'm really impressed. Please leave a few bugs to me lol.
How were you able to figure out all of those specific bugs?

comment:3 by sluicebox, 6 years ago

*blush* Thanks!

I'm afraid the answer is that there's something wrong with me!

The Laura Bow games are my favorites so it's a combo of a debilitating good memory for unhelpful details, terrible luck (but in a good way?), note taking, and I wrote some programs to help. Some of these bugs are turning up as part of a larger investigation. Maybe these games do teach good detective skills!

In this case I was working the backrub bug and setting up saves for it when I tripped this, temporarily confusing things even further, so good bad luck.

comment:4 by digitall, 6 years ago

Keywords: original has-pull-request added

comment:5 by bluegr, 6 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

Very nice work! The pull request has been merged, so this can be closed now

comment:6 by sluicebox, 3 years ago

Owner: changed from bluegr to sluicebox
Note: See TracTickets for help on using tickets.