Opened 5 years ago

Closed 5 years ago

#10969 closed defect (fixed)

SCI: LB2: Floppy version broken by recent commit

Reported by: sluicebox Owned by: bluegr
Priority: blocker Component: Engine: SCI
Version: Keywords:
Cc: bluegr Game: Laura Bow 2: The Dagger of Amon-Ra

Description

A recent commit broke LB2 floppy, crashing on kernel init:

​https://github.com/scummvm/scummvm/commit/9551e64bdfc05954f41b665a3ae706f46304347e

The crash involves selector names and this is one of the weird games that didn't ship with selector names.

bool Kernel::selectorNamesAvailable() {
	return !_selectorNames.empty(); // crash: _selectorNames isn't set
}

Change History (2)

comment:1 by Filippos Karapetis <bluegr@…>, 5 years ago

In d2f5023e:

SCI: Do not apply script patches when checking for static selectors

Fixes bug #10969

comment:2 by bluegr, 5 years ago

Owner: set to bluegr
Resolution: → fixed
Status: new → closed

Thanks for your report! Fixed. Closing this

Note: See TracTickets for help on using tickets.