FOTAQ: Loading save game from the launcher doesn't work

[criezy]

Loading a savegame from the launcher for Flight of the Amazon Queen doesn't work in ScummVM 2.1.0 and current master. Instead of loading the save game it plays the intro and then gets to the start of the game. I have also checked that it is working in ScummVM 2.0.0, and thus is a regression between 2.0.0 and 2.1.0.

Loading after starting a game works properly. The issue only occurs when loading from the launcher.

I tested on macOS but a user reported loading not working on Windows with 2.1.0 and working with Android with 2.0.0.

[criezy]

Savegame for FOTAQ

[criezy]

I bisected between versions 2.0.0 and 2.1.0 and the first bad commit is de879dd5380c16b03fb2c74d6580bd485f3487f5 [QUEEN: Disable load/save until game is properly initialised]

[criezy]

That change comes ​libretro#114 via ​PR #1855.

[The game engine for 'Flight of the Amazon Queen'] allows you to load a previous save before the game is properly initialised. At best, this leads to undefined behaviour. Most of the time it causes a segfault.

[criezy]

This is fixed by commit 60de72a73e75a2ceabd42229e65a33f95fcd7ead.