Crash on start with Mac OSX 10.12.6 + macintosh Monkey Island 1 Files

[labbott]

On both the latest stable and osx_intel-master-19fe3521 (Mar 15 nightly)
I get a crash immediately on launching Monkey Island 1. I briefly see the Lucas Arts logo and then a crash. Looks like it is crashing in the Audio thread (full log attached)

Thread 8 Crashed:: com.apple.audio.IOThread.client
0 org.scummvm.scummvm 0x00159672 0x1000 + 1410674
1 org.scummvm.scummvm 0x0015a4df 0x1000 + 1414367
2 org.scummvm.scummvm 0x031d71f9 Audio::CopyRateConverter<false, false>::flow(Audio::AudioStream&, short*, unsigned int, unsigned short, unsigned short) + 213
3 org.scummvm.scummvm 0x0252f73b 0x1000 + 38987579
4 org.scummvm.scummvm 0x02530839 0x1000 + 38991929
5 org.scummvm.scummvm 0x024429cc 0x1000 + 38017484
6 org.scummvm.scummvm 0x02442962 0x1000 + 38017378
7 org.scummvm.scummvm 0x0266e74f 0x1000 + 40294223
8 com.apple.audio.units.Components 0x1091fae6 AUInputElement::PullInput(unsigned long&, AudioTimeStamp const&, unsigned long, unsigned long) + 172
9 com.apple.audio.units.Components 0x107feb3e AUInputFormatConverter2::InputProc(OpaqueAudioConverter*, unsigned long*, AudioBufferList*, AudioStreamPacketDescription, void*) + 266
10 com.apple.audio.toolbox.AudioToolbox 0x9327b9c3 AudioConverterChain::CallInputProc(unsigned long) + 377
11 com.apple.audio.toolbox.AudioToolbox 0x9327b7c2 AudioConverterChain::FillBufferFromInputProc(unsigned long*, CABufferList*) + 382
12 com.apple.audio.toolbox.AudioToolbox 0x9325985f BufferedAudioConverter::GetInputBytes(unsigned long, unsigned long&, CABufferList const*&) + 173
13 com.apple.audio.toolbox.AudioToolbox 0x93231cbb CBRConverter::RenderOutput(CABufferList*, unsigned long, unsigned long&, AudioStreamPacketDescription*) + 83
14 com.apple.audio.toolbox.AudioToolbox 0x932596e8 BufferedAudioConverter::FillBuffer(unsigned long&, AudioBufferList&, AudioStreamPacketDescription*) + 262
15 com.apple.audio.toolbox.AudioToolbox 0x9327b4ff AudioConverterChain::RenderOutput(CABufferList*, unsigned long, unsigned long&, AudioStreamPacketDescription*) + 101
16 com.apple.audio.toolbox.AudioToolbox 0x932596e8 BufferedAudioConverter::FillBuffer(unsigned long&, AudioBufferList&, AudioStreamPacketDescription*) + 262
17 com.apple.audio.toolbox.AudioToolbox 0x932241f4 AudioConverterFillComplexBuffer + 313
18 com.apple.audio.units.Components 0x107fe43f AUInputFormatConverter2::PullAndConvertInput(AudioTimeStamp const&, unsigned long&, AudioBufferList&, AudioStreamPacketDescription*, bool&) + 139
19 com.apple.audio.units.Components 0x107fe26a AUConverterBase::RenderBus(unsigned long&, AudioTimeStamp const&, unsigned long, unsigned long) + 562
20 com.apple.audio.units.Components 0x10922bd5 AUBase::DoRenderBus(unsigned long&, AudioTimeStamp const&, unsigned long, AUOutputElement*, unsigned long, AudioBufferList&) + 141
21 com.apple.audio.units.Components 0x1092290c AUBase::DoRender(unsigned long&, AudioTimeStamp const&, unsigned long, unsigned long, AudioBufferList&) + 552
22 com.apple.audio.units.Components 0x10801a5e AUHAL::AUIOProc(unsigned long, AudioTimeStamp const*, AudioBufferList const*, AudioTimeStamp const*, AudioBufferList*, AudioTimeStamp const*, void*) + 2756
23 com.apple.audio.CoreAudio 0x93e5cf16 HALC_ProxyIOContext::IOWorkLoop() + 7936
24 com.apple.audio.CoreAudio 0x93e5adc4 HALC_ProxyIOContext::IOThreadEntry(void*) + 236
25 com.apple.audio.CoreAudio 0x93e8b813 _ZN19HALC_ProxyIOContextC2Emj_block_invoke + 20
26 com.apple.audio.CoreAudio 0x93e5ac97 HALB_IOThread::Entry(void*) + 71
27 libsystem_pthread.dylib 0xa17e3047 _pthread_body + 184
28 libsystem_pthread.dylib 0xa17e2f8f _pthread_start + 243
29 libsystem_pthread.dylib 0xa17e284a thread_start + 34

Also tried turning off audio as a local override and it didn't help. This also seems to happen on the Fedora packaged version (didn't check the crash report to see if it was the same place) so it might be that my files are corrupt. These are old macintosh files:

$ md5sum MONKEY.*
2ccd8891ce4d3f1a334d21bff6a88ca2 MONKEY.000
6ffd00f766417c1ed520f3fddc949fa3 MONKEY.001

[labbott]

Turns out my original Mac Binary was 0 bytes so it was failing to parse anything. I think this is a case of the error handling could be better but it does seem to work if I remove the empty file. Mostly sad that I seem to have lost all copies of the binary :(

I'm just going to close this.