KYRA: Defeating EOB II final boss will result in a segmentation fault

[bjarketrux]

ScummVM 2.1.1 (Jan 19 2020 21:34:26)

Defeating the final boss will result in a segmentation fault.

Terminal output: "Segmentation fault: 11"
MacOS report view:
"
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000023
Exception Note: EXC_CORPSE_NOTIFY
"

Steps to reproduce:

• Load the save game.
• Defeat the final boss (side-step and melee attack).
• On final hit he fades out and ScummVM exits

DOS/English version from gog.com

MacOS 10.14.6

[athrxx]

I have tried to reproduce this issue with Windows and Linux (Kubuntu). Both ports work fine without issues. Also, valgrind does not give any evidence of invalid memory access. Since I have no way of testing MacOS I have renamed the ticket, so that someone on that OS may have a look at it. There is currently no way for me to fix this.

[bjarketrux]

I just tried it on windows and got somewhat similar crash.
I see the first part of the animation where the dragon is lying slayed (no music though).
Then it crashes. The log: WARNING: Couldn't find music file: '.ADL'!

This was a direct download form GOG. I will try to see if I'm missing a ADL file.

[bjarketrux]

All files seems to be there. Compared to another source...
By the way windows test machine was running ScummVM 2.1.1a

Also tried to disable sound but sound there is no matter what.

[athrxx]

Okay, that's weird. The engine should look for 'FINALE1.ADL' and not just '.ADL'.

Are you using the ScummVM build from ​https://www.scummvm.org/frs/scummvm/2.1.1/scummvm-2.1.1a-win32-x86_64.zip?

I'd have to check whether anything is wrong with that build...

How do the latest development builds work for you? (whichever of these suits you best)

​https://buildbot.scummvm.org/snapshots/master/mingw-w64-master-latest.zip
​https://buildbot.scummvm.org/snapshots/master/mingw-w32-master-latest.zip
​https://buildbot.scummvm.org/snapshots/master/osx_intel-master-latest.tar.xz
​https://buildbot.scummvm.org/snapshots/master/osx_x64-master-latest.tar.xz

[bjarketrux]

Okay okay okay
The (Windows) version i had was "scummvm-2.1.1a-win32.exe" (has the problem)
I tried your download link "scummvm-2.1.1a-win32-x86_64.zip" (has the problem)

Then I tried "mingw-w64-master-latest.zip" and it works!!
Another thing: As soon as I started the game it used my test setting for PC speaker. So the snapshot honers the audio settings. Tried with both PC and Adlib and both works for the Snapshot edition.

Sorry for not testing with it from the beginning...

[athrxx]

Thanks for all the testing. So maybe there is something off with the official 2.1.1 build. I'll download and test it myself...
Even if there is nothing in need of fixing in the code at the moment we still might have to replace that build on the download page.

Yes, I've added some audio stuff since the 2.1.1 release (support for PC speaker and for "no sound" setting).

I've renamed the ticket again, since it isn't a MacOS issue after all.

[athrxx]

I close this as outdated, since it works in current master and it should also work in the next release which will be based on that.