WIN32: ScummVM crashes when no audio devices are present

[jeditobe]

scummvm-2.1.1-win32 and scummvm-2.1.2-win32 no longer work in Windows XP 32 bit without sound card

Virtual Box 5.2.18, no soundcard, Win XP S33

Same OS but WITH SoundCard:

[lotharsm]

"Regression" starting with ScummVM 2.1.1 since that was the first version that came with TTS enabled by default on the Win32 platform.

It looks like the Win32 TTS code is not checking (or gracefully switching to the "not initialized" state when there are no audio devices present:

Thread 1 received signal SIGSEGV, Segmentation fault.
WindowsTextToSpeechManager::updateVoices (this=0x32f75b0)
    at backends/text-to-speech/windows/windows-text-to-speech.cpp:470
470             _voice->SetVolume(0);
(gdb) backtrace
#0  WindowsTextToSpeechManager::updateVoices (this=0x32f75b0)
    at backends/text-to-speech/windows/windows-text-to-speech.cpp:470
#1  0x000000000052ea05 in WindowsTextToSpeechManager::setLanguage (
    this=this@entry=0x32f75b0, language=...)
    at backends/text-to-speech/windows/windows-text-to-speech.cpp:348
#2  0x00000000004799de in GUI::GuiManager::initTextToSpeech (
    this=this@entry=0xd177f00) at gui/gui-manager.cpp:659
#3  0x000000000047a638 in GUI::GuiManager::GuiManager (this=0xd177f00)
    at gui/gui-manager.cpp:81

[lotharsm]

@jeditobe, can you please try the latest snapshot at ​https://www.scummvm.org/frs/daily/scummvm-snapshot-win32.exe? This version worked fine for me since it contains a fix.

Please also let me know if this fixes your issues with Windows 2003, since I suspect it doesn't have the TTS stuff. However, ReactOS still might be broken, but that's a whole other topic.

[jeditobe]

it works! looks like this bug is fixed

[jeditobe]

ReactOS issue is fixed as well \0/

[SupSuper]

Fixed by ​https://github.com/scummvm/scummvm/commit/9a3e420