SCI: SQ5 Mouse cursor displaying incorrect icon

[Bill-Bull]

In this game, TAB is a keyboard shortcut to open the inventory. However, if you use TAB to open the inventory, select an item, and then close the inventory (either by clicking OK or pressing ESC), the mouse cursor will be displaying the same icon you had selected before accessing the inventory. It is only a visual bug, however, and you can still use the item you've selected, only with the wrong mouse cursor icon.

I have confirmed that this bug is present also in Sierra's interpreter, using DOSBox.

*ScummVM versioninfo=2.2.0git8444-g7521cc5f9e
*DOS/English version of the game
*Save game is attached. To replicate, press TAB to open the inventory, choose an item and close the inventory (either by clicking OK or pressing ESC)

[sluicebox]

I took a look, I agree that this is worth fixing. It's recoverable but it puts the game in a state that sure seems broken. If you select an item you can't use in the current room and it gives you a walk icon then clicking walk doesn't work anywhere.

That said, I spent a while on it last week, and it seems hard. I'm also a little burned out on iconbar/cursor bugs at the moment.

[sluicebox]

This script bug is fixed in: ​https://github.com/scummvm/scummvm/commit/46771958fa442a5737ddca48563ca260898ccf59

I had written this off twice as maybe not being doable, but I just needed to look at it with fresh eyes (and forget everything from the past year!)

Thanks for reporting this, the fix will show up in the next daily build.