Opened 4 years ago
Closed 4 years ago
#11625 closed defect (fixed)
CINE: OS: Game doesn't support more than 20 savegames (and conveys that information very poorly)
| Reported by: | Kurufinwe21 | Owned by: | karisal |
|---|---|---|---|
| Priority: | high | Component: | Engine: Cine |
| Version: | Keywords: | ||
| Cc: | Game: | Operation Stealth |
Description
ScummVM 2.2.0git8525-g693f4f7554 (Aug 26 2020 07:16:24) on Windows 10 (build 2004)
Playing the French DOS EGA version of Operation Stealth.
This is using the ScummVM save menus (not the game's original ones).
The game only supports 20 save slots (19 saves + slot 0 for the auto-save). If you try to create another save slot after that, the menu just closes and throws you back to the game when you click New Save.
I know the original engine was limited to 20 save slots, but maybe ScummVM could allow more? In any case, it should display a message of some sort rather than just throw you out of the menu.
Change History (5)
comment:1 by , 4 years ago
| Summary: | CINE: OS: Game doesn't support more the 20 savegames (and conveys that information very poorly) → CINE: OS: Game doesn't support more than 20 savegames (and conveys that information very poorly) |
|---|
comment:2 by , 4 years ago
| Priority: | normal → high |
|---|
follow-up: 5 comment:4 by , 4 years ago
Waiting for this pull request to be merged into the upcoming release branch (2.2.0). If it is merged then a stable build of ScummVM can be used to test it (See Please help us with testing upcoming ScummVM 2.2.0 release). Thank you!
In the pull request support for using 100 savegames rather than just 20 was added. All of the savegames can be accessed either by using the ScummVM's savegame handling UI or the Cine engine's original savegame handling UI (The latter was augmented by adding a menu for choosing the group of 20 savegames that are shown on screen).
P.S. The "New save"-button's state handling is still broken and it is related to ScummVM's general UI code, not Cine engine code AFAIK.
comment:5 by , 4 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Replying to karisal:
Waiting for this pull request to be merged into the upcoming release branch (2.2.0). If it is merged then a stable build of ScummVM can be used to test it (See Please help us with testing upcoming ScummVM 2.2.0 release). Thank you!
In the pull request support for using 100 savegames rather than just 20 was added. All of the savegames can be accessed either by using the ScummVM's savegame handling UI or the Cine engine's original savegame handling UI (The latter was augmented by adding a menu for choosing the group of 20 savegames that are shown on screen).
P.S. The "New save"-button's state handling is still broken and it is related to ScummVM's general UI code, not Cine engine code AFAIK.
The pull request has been merged to branch-2-2. You can try it out with the stable builds of ScummVM. I created another bug report (#11645) for the "New save"-button's state handling related part ("UI: "New save"-button state handling is broken.").
I think there is a bug in the graying out of the "New save"-button. It does not work at all currently in ScummVM in any engine. One can try this out by making the maximum amount of saves in a given engine and turning on the thumbnail view. The "New save"-button always remains active which it should not be when there are no more new slots available. The bug is in the non-engine specific code handling the "New save"-button's state. This comment was written based on a memory of debugging and thus I don't remember clearly the methods involved.
If someone else more knowledgeable in the general savegame UI handling code could please take a look into this it would be nice. Thank you! That would at least fix a part of this if not all.