Opened 4 years ago

Closed 45 hours ago

#11858 closed defect (fixed)

EMI: Launcher sees the list of EMI saved games but crashes loading them

Reported by: sev- Owned by: bluegr
Priority: normal Component: Engine: Grim
Version: Keywords:
Cc: Game: Escape from Monkey Island

Description

Games saved by EMI are listed if the button "Load" is clicked while we are on an EMIDEMO entry.
This behaviour does not exist with GRIM and its demo.

If such a file is validated, thats causes a segmentation fault, here with a read at address 0 on a font loading:

GrimEngine::savegameRestore() started.
==13643== Invalid read of size 8
==13643== at 0x48A0BA: Grim::Font::load(Common::String const&, Common::SeekableReadStream*) (font.cpp:51)
==13643== by 0x48A59A: Grim::Font::restoreState(Grim::SaveGame*) (font.cpp:159)
==13643== by 0x4204BC: Grim::PoolObject<Grim::Font>::Pool::restoreObjects(Grim::SaveGame*) (pool.h:324)
==13643== by 0x41E0F8: Grim::GrimEngine::savegameRestore() (grim.cpp:962)
==13643== by 0x41CA09: Grim::GrimEngine::mainLoop() (grim.cpp:768)
==13643== by 0x41C712: Grim::GrimEngine::run() (grim.cpp:398)
==13643== by 0x40E19A: runGame(Plugin const*, OSystem&, Common::String const&) (main.cpp:285)
==13643== by 0x40D168: scummvm_main (main.cpp:562)
==13643== by 0x40BB2C: main (posix-main.cpp:45)

Should EMI saved games not be listed in the load window of EMIDEMO?

https://github.com/residualvm/residualvm/issues/1612

Change History (3)

comment:1 by aquadran, 3 years ago

I can confirm that. I guess this need some filtering from full vs demo

comment:2 by Filippos Karapetis <bluegr@…>, 45 hours ago

In 011d0a1f:

GRIM: Do not list saves for demos - bug #11858

comment:3 by bluegr, 45 hours ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.