Opened 4 years ago

Closed 4 years ago

#11981 closed defect (fixed)

TWINE: Manual mode for agressive behaviour doesn't work as expected

Reported by: vvs- Owned by: vvs-
Priority: normal Component: Engine: TwinE
Version: Keywords:
Cc: Game: Little Big Adventure

Description

In manual mode space and arrows should select punches and kicks. Currently up arrow just freezes and left/right arrows both punch and rotate.

Change History (15)

comment:1 by vvs-, 4 years ago

Summary: Manual mode for agressive behaviour doesn't worl as expectedManual mode for agressive behaviour doesn't work as expected

comment:2 by mgerhardy, 4 years ago

Thanks a lot for the report.

I've just published a potential fix to master. It would be nice if you could test the next nightly build and report back.

comment:3 by vvs-, 4 years ago

Something else is broken, it can't detect the game now :(

comment:4 by vvs-, 4 years ago

Ok, found the reason - I've messed up permissions.

Your fix is working, thank you. But there is still one difference: in the original these actions auto repeat if you hold the keys, while in TwinE they doesn't.

comment:5 by mgerhardy, 4 years ago

This is all about the input system refactoring to the scummvm keymapper. The issue at https://bugs.scummvm.org/ticket/12004 is related

comment:6 by mgerhardy, 4 years ago

Movements::processBehaviourExecution uses toggleActionIfActive and thus only executes the action once.

d4ba608c77db6462de4e65fd68dc1d8a2cb3085b should fix the issue

comment:7 by mgerhardy, 4 years ago

What I am not sure about is the fact that the actor now also rotates while pressing left right attack.

comment:8 by vvs-, 4 years ago

Not only he rotates, but the combo with up arrow doesn't work again.

comment:9 by sev-, 4 years ago

Summary: Manual mode for agressive behaviour doesn't work as expectedTWINE: Manual mode for agressive behaviour doesn't work as expected

comment:10 by vvs-, 4 years ago

BTW, in the original Twinsen slightly moves ahead at each strike, and the distance is further for kick.

comment:11 by mgerhardy, 4 years ago

https://github.com/scummvm/scummvm/commit/a9960cfea5ba666bbdc1935b8338ab91cca82dff Yet another attempt to fix the regression. I'm not yet sure about the slightly moves you mentioned, will investigate.

comment:12 by mgerhardy, 4 years ago

The actors moves forward while attacking and in combination with ticket: https://bugs.scummvm.org/ticket/12046 I think this is fixed now.

comment:13 by vvs-, 4 years ago

Twinsen still rotates while punching. And the kick using up arrow+space combo still doesn't work.

comment:14 by mgerhardy, 4 years ago

The manual mode kick is fixed in 0da5fc1d24c3b65bd86483dd41ddf8b7e51aad98

comment:15 by vvs-, 4 years ago

Owner: set to vvs-
Resolution: fixed
Status: newclosed

Thanks!

Note: See TracTickets for help on using tickets.