MOHAWK: Custom engine options no longer shown for Myst and Riven

[criezy]

In current 2.3.0git version the custom Engine options are no longer displayed for the mohawk engine (for Myst and Riven) in the Edit game dialog. It is displayed when accessing the options from a running game (with F5 > Options).

It is properly displayed in the 2.2.0 release in the Edit game dialog.

I suspect this is related to the changes for the detection plugins.

[macca8]

I can confirm this issue with Riven on macOS.

With respect to the 2.3.0git version, I can trace this issue back to at least this daily build: 2.3.0git9567-g1fef4148a1 (Oct 24 2020 07:06:36).

Both the 2.2.0 release and the latest daily stable builds (2.2.1pre123 - 14 Nov 2020) properly display the Engine options tab in the Edit Game dialog.

[eriktorbjorn]

I could be wrong, but I'm getting the impression that it was a deliberate decision to move the settings to a dialog. I found these two commits, at least:

​https://github.com/scummvm/scummvm/commit/1be3c3c7c42aa49e06d427fd22d656b1a1b98cdc
​https://github.com/scummvm/scummvm/commit/1f5d4d1fdd31e72f7d3981a10b86e4d62253320b

[criezy]

From what I can see the aim of those commits is to unify various options dialogs. But it does not seem to me that making it available only in-game and removing all custom options from the edit game dialog was done on purpose.

[ccawley2011]

This is fixed by ​https://github.com/scummvm/scummvm/pull/3230

[macca8]

Replying to eriktorbjorn:

I could be wrong, but I'm getting the impression that it was a deliberate decision to move the settings to a dialog. I found these two commits, at least:

​https://github.com/scummvm/scummvm/commit/1be3c3c7c42aa49e06d427fd22d656b1a1b98cdc
​https://github.com/scummvm/scummvm/commit/1f5d4d1fdd31e72f7d3981a10b86e4d62253320b

Can't speak for Myst, but originally Riven's custom options were only accessible via a standalone dialog, accessible in-game by pressing F5.

This was changed to allow direct access to these options via the GMM (by adding a Game tab to its Options Menu) as an alternative to the original dialog, providing simplified access to all of Riven's functions via a single dialog. As part of this change, F5 was reassigned to the GMM through the Riven keymap (an alternative to the globally available Ctrl+F5), leaving the original dialog unassigned but accessible via the Riven keymap at the user's discretion.

Further to this, an Engine tab was added to the Edit Game dialog to mirror the in-game Game tab, allowing the user the discretion to modify the options before lauching the game. It's this missing Engine tab that's the source of this bug report.