AGS: Captain Disaster in Death Has a Million Stomping Boots - Saves made through ScummVM can crash original save logic

[joeraz]

In the original interpreter for "Captain Disaster in Death Has a Million Stomping Boots", all saves the player makes are automatically prefixed with the current date and time. However, this rule is not enforced by saves made through the ScummVM save window, and is also not followed by ScummVM's autosaves.

The original in-game save logic expects these prefixes to exist. This can ultimately crash the game if a player first saves the game through ScummVM, and then attempts to save over that save from the original save logic.

I believe the game is looking for the date in the save file it is trying to save over to replace it, but crashes the game because it can't find the date.

The save I attached to ticket 12444 was created with the ScummVM save window and can trigger this issue.

[dreammaster]

Checked with the new codebase, and the crash no longer occurs