Opened 3 years ago
Closed 3 years ago
#12789 closed defect (fixed)
Compilation failure due usage macro remove()
Reported by: | fedor4ever | Owned by: | ccawley2011 |
---|---|---|---|
Priority: | normal | Component: | Engine: SLUDGE |
Version: | Keywords: | ||
Cc: | Game: |
Description
In symbian port remove() declared as macro sibling for unlink() function in SDK header. Long ago with kind help ScummVM team was invented macro SYMBIAN_USE_SYSTEM_REMOVE. I opened pr - https://github.com/scummvm/scummvm/pull/3100 - long ago but it was declined.
Symbian port comes to buildbot soon and such thing shoud be resolved. That engine doesn't kill symbian port. Any ideas for fix?
Error log:
make: *** [LIBRARYSLUDGE] Error 2 /Symbian/Projects/SDL/scummvm/engines/sludge/builtin.cpp: In function 'Sludge::BuiltReturn Sludge::builtIn_deleteFile(int, Sludge::LoadedFunction*)': /Symbian/Projects/SDL/scummvm/engines/sludge/builtin.cpp:2077:39: error: 'remove' was not declared in this scope; did you mean 'wremove'? 2077 | fun->reg.setVariable(SVT_INT, remove(nam.c_str())); | ^~~~~~
Change History (2)
comment:1 by , 3 years ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → pending |
comment:2 by , 3 years ago
Status: | pending → closed |
---|
The pull request has been merged, thus I'm closing this
Note:
See TracTickets
for help on using tickets.
This should be fixed by PR #3250.