SCI: PQ4 (CD): German CD Version crash when entering the options in the game

[gabberhead]

i Have the daily build from 4.9.2021. and when i start the game, i can play it without problem. but when i try to enter the options menu, the game crashes with the following message:

ERROR: Failed to load mem 0000:0000!

Then i tried the latest offical version 2.2.0 and the problem is the same.

The crash happens only with activated high resolution option under the engine in the options. When i deactivate it, i can enter the menu without a crash.

Then i tried the official 2.1.2 version, and with that version, the problem is gone. i can enter the menu without the crash with and without the high resolution option.

The Problem is also described here:

​https://forums.scummvm.org/viewtopic.php?f=2&t=16367

[antoniou79]

I'm adding my comment from the forum thread, in case it might be helpful:
With the kDebugLevelGraphics enabled, the output at the error mark is:

kAddScreenItem 36:1e92 (iconText)
Failed to load mem 0000:0000!

This is triggered in ScreenItem::setFromObject() (screen_item32.cpp)
​https://github.com/scummvm/scummvm/blob/2d50ec4a412b9c807cc305679bbd8df979c56861/engines/sci/graphics/screen_item32.cpp#L172

By (crudely) removing the the applyPatch() line in script_patches.cpp, the error no longer happens, but then the PQ4 patch for subtitles+audio option in the GUI is no longer functional.
​https://github.com/scummvm/scummvm/blob/2d50ec4a412b9c807cc305679bbd8df979c56861/engines/sci/engine/script_patches.cpp#L22233

So the error is related to the patch application, which does not seem to "agree" with the DEU version.

I don't know why it is connected to the "high resolution" engine option though.

[eriktorbjorn]

I don't know why it is connected to the "high resolution" engine option though.

At least in the English version, I only see the speech/text option in the high-resolution version:

Not in the low-resolution one:

But I don't know if that means they're handled by different scripts or not.

Edit: Apparently it's the same script. From script_patches.cpp:

// Add support for simultaneous speech & subtitles to the in-game UI.
// The original game code has code paths for lo-res mode but only creates the
// buttons in hi-res mode, so the lo-res code paths are removed to gain more
// space for the patch.
// Applies to: English CD
// Responsible method: iconText::init, iconText::select
static const uint16 pq4CdSpeechAndSubtitlesSignature[] = {

[gabberhead]

@eriktorbjorn

It's the same behavior in the german Version and scummvm 2.1.2. The Option is only available in high Resolution. But it's not possible to activate or deactivate speech or subtitles from games options ui.
But with scummvm official Version 2.2.0 and in the daily builds, the game crashes when i try to enter the options in high resolution. In low resolutions there is no crash and also the option to activate or deactivate speech and subtitles is not visible.

[bluegr]

Should be fixed in df062c6baadfd9e6b01c80ec974a53538dac17f3:
​https://github.com/scummvm/scummvm/commit/df062c6baadfd9e6b01c80ec974a53538dac17f3

The fix will be available in the next daily version. Could you please test if the menu is working correctly for your version?

[gabberhead]

it works again. tested with the newest daily build. thanx.

[bluegr]

Thanks!