Opened 3 years ago
Closed 3 years ago
#12977 closed defect (fixed)
Engines: Incorrect MetaEngine::getSavegameFile implementations
| Reported by: | criezy | Owned by: | orgads |
|---|---|---|---|
| Priority: | normal | Component: | Common |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
The default MetaEngine::getSavegameFile one of two schemes:
target.####ifkSavesUseExtendedFormatis supportedtarget.s##otherwise
Yet many engines do not support kSavesUseExtendedFormat and do not reimplement getSavegameFile, but are still using the first scheme.
For example with the lure engine, getSavegameFile(1, "lure") returns lure.s01, but the name actually used by the engine is lure.001.
As a result functions using getSavegameFile(), such as copySaveFileToFreeSlot() fail.
Having a correct implementation for all engines would also allow to simplify some code, such as removeSaveState() which would no longer need to be reimplemented in many engines.
Change History (2)
comment:1 by , 3 years ago
| Component: | --Unset-- → Common |
|---|---|
| Owner: | set to |
| Resolution: | → pending |
| Status: | new → pending |
comment:2 by , 3 years ago
| Resolution: | pending → fixed |
|---|---|
| Status: | pending → closed |
Note:
See TracTickets
for help on using tickets.
https://github.com/scummvm/scummvm/pull/3429