SCUMM: MM (NES-EU-ES) - Last letters retained in screen/missing letters

[LukasThyWalls]

Hello.

Tested with 2.5.0 and last SVN from today, the issue affects at least only Maniac Mansion NES Europe/Spanish (I don't know if other non-English languages are affected, but English US is not).

The issue can be seen right in the intro: The last letters in the upper text box showed in some lines remains stuck there (See scummvm_maniac-nes-es_IntroLetterLeftover.gif attached).
This happen in both lines in the upper text box, and it's not only in the intro, also happens with other lines that reach that part of the screen in other parts of the game (See scummvm_maniac-nes-es_EndLettersLeftovers.jpg attached from the end of the game).
Those letters remains there, they shows above other letters in sentences that reach that part of the screen, with only when an space take that place, it shows a blank space since then. Also the letter disappears if i reset the game or load a save game, but i can beat the game with "letters leftovers" and see the intro and the choose kids screen with that letters still there.

In the original game, (obviously) that not happens, but also i found that in ScummVM is missing a letter: In the original intro shows "LUCASFILM GAMES" and in ScummVM is "LUCASFILM GAME" (And that E got stuck). (See original_maniac-nes-es_Intro.gif). I don't know if that happens with other lines in the game yet.

It's seems that the size of the upper lines box and how it's cleared it's not set or is used differently in the Spanish version (at least).

--

NOTE: This is a issue redone for #3594, that is a very old report from sf that was mid-fixed but not entirely, and the only thing i can do is close it to update, so i will report it again and mark the originals as a duplicate.

--

[LukasThyWalls]

Doing more testing with the original game compared to the ScummVM version, it seems the text box is missing the last letter in each line (in the original game they reach the left side of the screen with no margin, although in the right side there is a margin) and the first second-to-last letter of each line is "retained" in screen putting it above any other letter that need to took that place.

In fact, in ScummVM the sentence line text and item list reach the left side of the screen with no margin, but the upper text box doesn't, but in the original game it does.

[AndywinXp]

It seems this workaround causes the problem: ​https://github.com/scummvm/scummvm/blame/e93a4c1599f593ae8e2afa7ae71b9a3a9923475a/engines/scumm/gfx.cpp#L763

[AndywinXp]

In 19397407:

SCUMM: MANIAC (NES): Fix mishandling/drawing of text area

While the workaround makes sense for room graphics,
I haven't yet see a reason why it should be used for the text
area as well...

This fixes #13107:
"SCUMM: MM (NES-EU-ES) - Last letters retained in screen/missing letters"

[LukasThyWalls]

Thanks!

I just tested the solution and It works, now there isn't letters retained... but now all text are moved to the left, they aren't centered as It was before (And like it is in the original NES version emulated).

I uploaded some new screenshots:

ScummVM 2.8.1 (old behaviour):

ScummVM 2.9.0 git (new patched behaviour):

NES emulated:

Maybe the margin in the left should be kept, but not in the right? I didn't test further in the original NES to see if the margin in the left is kept all times in the same place, but there it is.

Should I open a new ticket because this?

Thanks in advance!

[AndywinXp]

Hi, thanks for the follow-up. I fixed this as well.

[LukasThyWalls]

Hi!

Tested and working like the original behavior (only with a lack of a full playthrough to test all messages to see if all of them fit well).

Thanks!