When global setting is Speech, subtitles don't appear to games without speech

[orgads]

• In global settings, set Audio -> Text and speech to Speech
• Add a game without speech (GUIO_NOSPEECH)
• Audio settings for the game are disabled
• Start the game - it has no subtitles and no speech

[orgads]

Broke by ​https://github.com/scummvm/scummvm/pull/3420

scumm.cpp has this:

if (ConfMan.getBool("speech_mute") && ConfMan.getBool("subtitles"))

ConfMan.setBool("subtitles", true);

But with this change, none of them is set, so subtitles are not enabled.

[sluicebox]

I'm missing something; I'm unable to reproduce and I'm not seeing how this wouldn't mean there weren't already problems like this before the UI change.

Can you walk me through exact UI steps to reproduce this, starting with an empty scummvm.ini? The new Windows Portable Mode means you can just touch scummvm.ini in your exe directory and start experimenting, which is what I've been doing. You could attach that once you've got it in a broken state.

What games are you using? Are you seeing this in any engine besides SCUMM? I've been trying with a floppy version of Sam N Max since that's GUIO_NOSPEECH. I made the dialog change to fix an SCI GUIO_NOSPEECH game, so it seems likely this is engine-specific.

My commit changed the Edit Game dialog so that when the subtitle controls are disabled (such as for GUIO_NOSPEECH games) and changes are applied, "subtitles" and "speech_mute" keys are removed from the game-level config. This is consistent with the other UI code and fixed a bug where those config values were being set based on (undefined?) invisible state from disabled UI widgets. If the absence of those two keys from game-level config breaks subtitles... then shouldn't games have already been broken before the change? Adding GUIO_NOSPEECH games through the UI without changing defaults didn't set "subtitles" or "speech_mute". (That is, that was the behavior before and after the commit.)

Let's get this reproducing first, but might need to bring in a SCUMM expert.

[orgads]

Ok, I found out this only happens for SCUMM ultimate talkie versions with the monster file *removed*.

[sluicebox]

I'm removing myself from this ticket as we've established that my GUI fix was not a regression and that I don't know anything about the SCUMM engine =)

[bluegr]

The PR has been merged now, so this can be closed