Opened 3 years ago

Closed 4 days ago

#13216 closed defect (fixed)

WEB: "Other" screenshots page is broken

Reported by: Thunderforge Owned by: lephilousophe
Priority: normal Component: Web
Version: Keywords: screenshots
Cc: Game:

Description

On any screenshots page for a game or series (say Loom), at the bottom of the page is a "Back" button that goes up one level to the company category (in Loom's case, LucasArts).

Games that are in the "Other Games" category (such as Teen Agent) has a back button that goes to https://www.scummvm.org/screenshots/other, but this page results in the following error:

There was a problem processing your request:

Invalid category specified.

Initial findings

The "Invalid category specified" error is thrown on this line. The issue is that the page is looking for screenshots matching a company name of "Other", finds none, and throws an error.

The "Other" category is generated by this query for any company where no more than one game exists.

I also discovered that you can go to a game's screenshot page if the "other" in the URL is the company id. In other words, these two are interchangeable:

Possible Solutions

It seems that there are two solutions we could pursue:

  • Fix the query so that searching for "Other" results in a properly generated page showing screenshots for all companies that have a single game
  • Change the screenshot page so that the hyperlinks go to the company-specific pages (e.g. screenshots/metropolis/teenagent/) so that the Back button goes to the company page (screenshots/other/). Then the screenshots page has an "Other" category grouping that is purely cosmetic

Change History (2)

comment:1 by sev-, 5 days ago

The navigation has been fixed since. So, most of these bad links are now functioning properly.

However, one link is still broken:

  1. Open Screenshots
  2. Scroll down to "Other" games
  3. Click on the "Other" category, not individual ones. This leads to "invalid category specified"

Direct URL: https://www.scummvm.org/screenshots/other/

comment:2 by lephilousophe, 4 days ago

Owner: set to lephilousophe
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.