Opened 3 years ago
Closed 2 years ago
#13341 closed defect (fixed)
DIRECTOR: Star Trek Omnipedia Crashes to Debug prompt
Reported by: | jamie-marchant | Owned by: | rvanlaar |
---|---|---|---|
Priority: | normal | Component: | Engine: Director |
Version: | Keywords: | ||
Cc: | Game: |
Description (last modified by )
Trying to run Star Trek Omnipedia results in the error:
ERROR: Unknown key "5"!
Attachments (1)
Change History (12)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
Description: | modified (diff) |
---|---|
Summary: | Star Trek Onmipeida Crashes to Debug prompt → Star Trek Omnipedia Crashes to Debug prompt |
comment:3 by , 3 years ago
Thank you for reporting this bug.
Could you run scummvm with scummvm -d5 --debugflags=lingoexec
and post the log?
by , 3 years ago
Attachment: | scummvm.log added |
---|
comment:5 by , 2 years ago
Summary: | Star Trek Omnipedia Crashes to Debug prompt → DIRECTOR: Star Trek Omnipedia Crashes to Debug prompt |
---|
comment:6 by , 2 years ago
Thanks you for the log. The debug output itself is good.
I've looked at it and see the Error.
Unfortunately it doesn't give much context in identifying the problem.
For now my only advice is to try it after the summer.
There is a student actively working on support for Director 4.
comment:7 by , 2 years ago
It's almost the end of summer and the current daily builds still have the same problem.
comment:8 by , 2 years ago
Thank you for bringing the issue back at our attention.
There was a wrong check around this code. The requested value "5" didn't exist.
Not to get your hopes up. Now that the game continues past this point it reveals another bug.
I'ld like to close this ticket since the original issue is fixed. Feel free to open a new one so we can track it and keep communication open.
For reference, the commit that fixes the "5" bug: https://github.com/scummvm/scummvm/commit/1d88dabd70dc73fc586485be032135cfe3f19019
comment:9 by , 2 years ago
Yes you may close the ticket. Don't forget to report the other bug and when you do I'll subscribe to that ticket.
comment:10 by , 2 years ago
Hello,
The new bug was fixed. However this bug brought even more bugs to the forefront.
This game stores data in a text field. That data is parsed into a data structure called property arrays. In short, there are multiple bugs when converting the text to said data structure.
For reference:
https://github.com/scummvm/scummvm/commit/0c0863ce42a387766739f164fece8ae786027066
comment:11 by , 2 years ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Do I need to move data around? I read that was the case in some cases.