SCUMM: PAJAMA Multiple animation errors during Cheese & Crackers game during final cutscene

[Thunderforge]

During the final cutscene, Pajama Sam plays Cheese & Crackers with Darkness. However, there are a lot of errors with it:

1. The board isn't visible
2. The flashlight and the light it casts aren't visible
3. The left door isn't drawn
4. The right door "reflects" on the floor

See attached screenshots.

Reproduction Steps

1. Load the attached save game
2. Click on the door
3. Watch the cutscene. After about a minute, the scene in question will be played

Versions Tested

• ScummVM 2.1.0 (bundled with the Steam release), 2.5.1, and Nightly 2022-04-18
• Pajama Sam Steam version

[eriktorbjorn]

I can reproduce this with the Steam version, which ScummVM identifies as

Using gameid pajama, variant HE 100, extra Updated
  SCUMM version 6, HE version 100

I can't reproduce it with my other version, identified as

Using gameid pajama, variant HE 99, extra Updated
  SCUMM version 6, HE version 99

I'll see if I can figure out what they do differently, but I can't promise anything. I haven't looked much at the HE side of things.

[eriktorbjorn]

The main (possibly only?) missing object is drawn by a call to drawObject(), with obj = 2.

That prompts it to look for an IM01 resource to draw. I added some debug messages based on that, and this is what I saw in my HE99 version:

xpos: 7, ypos: 248, width: 64, height = 208
Searching... curpos = 8, totalsize = 15540
Looking for IM01 but seeing IMHD (size 30)
Looking for IM01 but seeing IM01 (size 15502)
Found it!

In the Steam version, I saw this instead:

xpos: 7, ypos: 248, width: 64, height = 208
Searching... curpos = 8, totalsize = 34
Looking for IM01 but seeing IMHD (size 26)
I give up

So for whatever reason, there was no image to be found?

[eriktorbjorn]

@sev asked me to add this information:

This is what ScummVM says for the version I have that works:

User picked target 'pajama1' (engine ID 'scumm', game ID 'pajama')...
   Looking for a plugin supporting this target... SCUMM [all games]
Using gameid pajama, variant HE 99, extra Updated
  SCUMM version 6, HE version 99
Using MD5 '898eaa21f79cf8d4f08db856244689ff'

And this is for the Steam version:

User picked target 'pajama-win' (engine ID 'scumm', game ID 'pajama')...
   Looking for a plugin supporting this target... SCUMM [all games]
Using gameid pajama, variant HE 100, extra Updated
  SCUMM version 6, HE version 100
Using MD5 '37aed3f91c1ef959e0bd265f9b13781f'

[eriktorbjorn]

By the way, is it a bug or a feature that the end credits appear at the bottom of the screen line-by-line rather than pixel-by-pixel?

[einstein95]

Running through VMware with HE version 100 and it shows the bug, so it's not on ScummVM's side
EDIT: Confirmed running the Mac side in QEMU

[antoniou79]

As I've mentioned on discord, my GOG version is detected as follows:

 User picked target 'pajama-win' (engine ID 'scumm', game ID 'pajama')...
 Using gameid pajama, variant , extra
   SCUMM version 6, HE version 80
 Using MD5 '672dec94b82f7f0877ebb5b5cf7f4bc1'

I can test any potential fixes if needed, but I cannot load the attached save, as ScummVM (2.6.0git, build from master HEAD, on Windows 10 x64 Pro) throws a segmentation fault:

Assertion failed: idx < _res->_types[type].size(), file engines/scumm/saveload.cpp, line 1280

So I'll have to play till the end. I understand that it's a small game anyway.

Edit: Testing with einstein95's debug shortcut, by jumping to room 58, my GOG version does not have the issue.

[einstein95]

Replying to antoniou79:

So I'll have to play till the end. I understand that it's a small game anyway.

Using the debug command room 58 skips straight to the cutscene in question

[BLooperZ]

It seems the image resources for objects 938 (door) and 939 (board/floor) are actually missing from Steam (HE100) version.
the resources only contain the image headers but does not containg the image data (26 bytes total).

There are several other images missing in other rooms but they are less noticable.

[Thunderforge]

Here are the images for reference

Note that the board and floor has an opaque black background, which covers up the black reflection marks on the floor so that it's not seen in game.

And it does appear to be just a matter of missing images, not an interpreter issue.

injecting the missing images as is from HE99 version to HE100 version seem to fix the issue, but I'm not sure if it's ok to create such patch

[Thunderforge]

Since it's a matter of missing images in the game files, it seems like our options are:

1. Do nothing. Children and nostalgic adults who buy the game on Steam are confused.
2. Add the missing images to ScummVM, but we are currently unsure of if we have permission.
   • Are we in contact with the IP owner? Can we ask their permission?
3. Create our own replacement images (under a GPLv3-compatible license) that are distinct from the ones in the game, then add those.

Are there other options? Option 2 would be the best if we could be sure that we won't have any rights issues by including them.