Opened 21 years ago
Closed 21 years ago
#1347 closed defect (fixed)
COMI: ASCII 0xb (11) not handled
| Reported by: | fingolfin | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | low | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Monkey Island 3 |
Description
In the german LANGUAGE.TAB file, in some strings the ASCII char 0xb (11) occurs. Historicaly, this is the "VT" (Vertical Tabulator) character.
ScummVM doesn't do anything to handle this char. Hence it is printed as a square (the symbol for unmapped chars). My guess is that in the original this string is treated somehow specially. However I have idea how exactly, since I can't run the original COMI myself.
A place to trigger this (the place I noticed it first) is in room 53. When Guybrush enters it the first time and sees Elain, he says: "HANG...ON...HONEY! I'M...GOING...TO...GET...YOU...OUT...OF...THIS...MESS" (string ID "BMGT302"). The translated version contains ascii 11. (The savegame on bug #809942 is really close to that spot, BTW).
It would be good if somebody with the original game could make a screenshot of how this is supposed to look, so we can find out what to do...
Ticket imported from: #864030. Ticket imported from: bugs/1347.
Attachments (2)
Change History (17)
comment:1 by , 21 years ago
comment:2 by , 21 years ago
I attached screenshot of that scene from original game [German version].
comment:3 by , 21 years ago
Assigning to you now there is a screenshot of the German version. I can't see anything particually amazing in the screenshot, but you didn't say where in the string the VT is :)
comment:4 by , 21 years ago
| Owner: | set to |
|---|
comment:5 by , 21 years ago
The screenshot is not of the german version, it's of an english version with the german LANGUAGE.TAB. The only thing it tells me is that the english comi.exe doesn't handle 0xb. So, either... 1) The german comi.exe does (and I have a pretty good idea how I'd think it would handle it) 2) They simply screwed up when translating, and inserted these chars, but then engine didn't handle them.
The only way to find out would be for somebody with the real german version to try this out.
comment:6 by , 21 years ago
| Owner: | removed |
|---|
comment:7 by , 21 years ago
I got the "real" one and can play it so I will post a screenshot as soon as i played there. Okay?
comment:8 by , 21 years ago
Didn't manage to take one but it looks just like Kaleks one so it's not inerpreted seemly
comment:9 by , 21 years ago
Sorry I meant to say Kirbens not Kaleks. I hope i didn't make somethin worse again.
comment:10 by , 21 years ago
| Owner: | set to |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
comment:12 by , 21 years ago
| Resolution: | invalid |
|---|---|
| Status: | closed → new |
comment:13 by , 21 years ago
Actually, this is not "invalid". We should at least ignore the 0x0B chars, as they are being printed as odd looking rectangles in the middle of the text.
BTW, the char does occur in the english texts as well. E.g. in the pirate songs (concrete example: in the "Plunder, Plunder, how I wonder" song).
I still think those chars were meant to produce a vertical tab and/or newline, so maybe we should consider implementing it that way (as an improvement over the original).
comment:14 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:15 by , 21 years ago
I added a hack to CVS which will make it simply ignore the 0xB. Not quite a nice solution, but it appears to actually match the behaviour of the original engine, as far as I can tell (plus we can always adjust it later on if necessary).
I attached screenshot of that scene from original game [English version].