LSL6 inventory items have incorrectly colored background

[RayKoopa]

• ScummVM 2.6.0git5915-gf29cdfcf46a (May 22 2022 09:53:09)
• Game language: English
• Game version: Hi-Res 1.000.000
• Windows 11 21H2 10.0.22000.675

Steps to reproduce:

• Start a new game.
• Look at the inventory panel at the top right.
• Optionally grab an item and notice it still has a black background.

The background color behind item graphics in the inventory panel at the top right is pure black (hex 000000) while it should match the surrounding panel's dark green color (hex 003B3B).

[sluicebox]

Hello! Thank you for reporting this. I confirmed with a playthrough video that indeed the inventory background is teal and not black: ​https://www.youtube.com/watch?v=0Bj3TSdYZNY

Mac version is also drawing black in ScummVM.

Bumping this to normal so that I can feel a greater sense of accomplishment if I fix it =)

[RayKoopa]

Sure, go ahead :) I didn't want to bug people too much about a relatively small thing like this so I created it with "Low".

[sluicebox]

Fixed in: ​https://github.com/scummvm/scummvm/commit/b74b93ad46e0d3e0c88f632b90f1c04bf81512a5

Well it turned out to be easy but I'm still going to cling to that sense of accomplishment =)

Thanks again for reporting. Good eye!

[RayKoopa]

You deserve the accomplishment. It seems to have to do with uninitialized memory?

[sluicebox]

Yes; it works by accident in the original.

The script chooses green or black based on a variable that is never set, so it's operating on "whatever happens to be there". We detect these errors and have a table of known offenders so we can reply with the value they need to work. Our workaround for this one was wrong, we were offering a zero but really it needs a non-zero value for the correct outcome.

[RayKoopa]

That's awesome! I enjoy how high level that fix for such a low level thing is. Thanks again for checking and fixing it.