Opened 2 years ago

Closed 2 years ago

#13615 closed defect (fixed)

DIRECTOR: regression in palette loading

Reported by: mistydemeo Owned by: mistydemeo
Priority: normal Component: Engine: Director
Version: Keywords:
Cc: mistydemeo Game:

Description

#3979 adjusted how palette loading works by loading a uint16 instead of a single byte. While this fixes the game mentioned in the PR (Seven Colours), it breaks at least one other, Japan Art Today #7. I've attached screenshots of the incorrect and correct colours.

Checking the palette in question, one of the loaded numbers for JAT07 is 65535, which sounds improbable. Clipping it to 255, like the old code incidentally did, fixes the issue. Seven Colours has valid palette indices above 255, though.

Attachments (2)

scummvm-japanart07-mac-ja-00000.png (7.0 KB ) - added by mistydemeo 2 years ago.
First screen - correct palette
scummvm-japanart07-mac-ja-00004.png (7.0 KB ) - added by mistydemeo 2 years ago.
First screen - incorrect palette

Download all attachments as: .zip

Change History (3)

by mistydemeo, 2 years ago

First screen - correct palette

by mistydemeo, 2 years ago

First screen - incorrect palette

comment:1 by mistydemeo, 2 years ago

Owner: set to mistydemeo
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.