Opened 2 years ago

Closed 2 years ago

#13622 closed defect (fixed)

GLK: SCOTT: Wrong background colour

Reported by: angstsmurf Owned by: angstsmurf
Priority: normal Component: Engine: GLK: Scott
Version: Keywords:
Cc: Game:

Description

The ZX Spectrum and Commodore 64 games have a cyan background behind the graphics instead of matching the text background below.

At line ​https://github.com/scummvm/scummvm/blob/34faf7f6ead4fc3cec65dc697b54a4d73d790c5f/engines/glk/scott/scott.cpp#L1623
glk_style_measure() is supposed to set the backgroundColor variable to the window background colour, but instead returns cyan (I think this might be colour -1).

There is a similar problem at ​https://github.com/scummvm/scummvm/blob/34faf7f6ead4fc3cec65dc697b54a4d73d790c5f/engines/glk/scott/seas_of_blood.cpp#L354

Attachments (2)

spatterlight_correct_colour.png​ (312.1 KB ) - added by angstsmurf 2 years ago.
scummvm_wrong_colour.png​ (935.8 KB ) - added by angstsmurf 2 years ago.

Download all attachments as: .zip

Change History (4)

by angstsmurf, 2 years ago

Attachment: spatterlight_correct_colour.png​ added

by angstsmurf, 2 years ago

Attachment: scummvm_wrong_colour.png​ added

comment:1 by angstsmurf, 2 years ago

Component: --Unset-- → Engine: GLK: Scott

comment:2 by criezy, 2 years ago

Owner: set to angstsmurf
Resolution: → fixed
Status: new → closed

Fixed by ​https://github.com/scummvm/scummvm/pull/4533, which is now merged.

Note: See TracTickets for help on using tickets.