Opened 2 years ago
Closed 2 years ago
#13634 closed patch (fixed)
Space Quest I VGA remake - Patched to Version 2.1
Reported by: | anssima | Owned by: | sluicebox |
---|---|---|---|
Priority: | normal | Component: | Engine: SCI |
Version: | Keywords: | SQ1VGA/SCI/DOS English | |
Cc: | Game: | Space Quest 1 |
Description (last modified by )
Space Quest I VGA - Version 2.1
https://www.vogons.org/viewtopic.php?t=53119
The page says: " It will not work with ScummVM."
Game starts and runs seemingly fine after patching the already added SQ1VGA v2.0. No further tests yet done with ScummVM v2.5.1
The game in 'SQ1VGA\' seems to be an unknown game variant.
Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:
Matched game IDs for the sci engine: sq1sci
{"resource.002", 0, "6827e20dc7a4a98c3c0f0e0be5f78cfe", 1169366},
{"resource.003", 0, "eae18632e2b70bbb688d679fb3022052", 1215951},
{"resource.000", 0, "a5eaa1c8cb48dced9bee23dfafaae19e", 1059308},
{"resource.001", 0, "15798bab768651db66819779af4185f0", 1039102},
{"resource.map", 0, "67a6792a8384fca77150e3b6c42a6f1e", 5991},
{"resource.004", 0, "252b9bda620fb47ef65b6e2cca3e73be", 1206005},
Change History (4)
comment:1 by , 2 years ago
Description: | modified (diff) |
---|
comment:2 by , 2 years ago
Description: | modified (diff) |
---|
comment:3 by , 2 years ago
comment:4 by , 2 years ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Added detection entry in: https://github.com/scummvm/scummvm/commit/6ea6667edfdf9932ee6de481c6a03c0414dac421
Thanks!
We have quite a few script patches for this game and this patch set rebuilds entire script resources with different bytecode than what we're expecting from the original. We "just" need to audit which of our patches get applied and which don't and verify that the results are acceptable.
I assume that the 2017 "It will not work with ScummVM" line refers to it not being detected as opposed to it being fundamentally incompatible. Or maybe they just didn't want to deal with supporting two interpreters.