Opened 2 years ago

Closed 2 years ago

#13831 closed defect (invalid)

SCI: Fix Detector To Not Flag Shivers 2, Betrayal at Krondar and Ankara for SCI

Reported by: Sonnelon-Crucia Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords: detection
Cc: Game:

Description

The game in 'Betrayal in Antara' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the sci engine: shivers2-win

{"ressci.001", 0, "ec1af49f636b8daaf4f37715a8844a44", 133654829},
{"resmap.001", 0, "3074d2d0d08c4279a645bf8be9b3f1f2", 17470},

Change History (5)

comment:1 by digitall, 2 years ago

Component: --Other--Engine: SCI
Keywords: unknown-game removed

As noted here, some later Sierra games have SCI resources, but are very different internally to the original SCI engine and thus are not supported:
https://wiki.scummvm.org/index.php?title=Sierra_Game_Versions#Not_SCI

This includes Shivers 2 and the two games starting with Betrayal.

Quoting the code:
https://github.com/scummvm/scummvm/blob/master/engines/sci/detection_tables.h#L5131


Shivers 2 doesn't contain SCI scripts. The whole game logic has
been reimplemented from SCI in native code placed in DLL files.
Each room has its own DLL file, and some SCI functions have been
reimplemented/rewritten for this purpose in native code. The
game and demo have all the resources of a SCI game, apart from
the SCI scripts themselves. Thus, they cannot be directly
supported, unless their whole room logic is rewritten from
scratch, which classifies Shivers 2 as "not SCI"


So these games will not be supported by the current SCI engine and the work to implement these would be extensive.

Will list this as "Won't Fix", but this bug should fix the detection to avoid flagging this as a supported game.

comment:2 by digitall, 2 years ago

Keywords: detection added
Summary: Unknown game variant for sciSCI: Fix Detector To Not Flagging Shivers 2, Betrayal at Krondar and Ankara for SCI

comment:3 by digitall, 2 years ago

Summary: SCI: Fix Detector To Not Flagging Shivers 2, Betrayal at Krondar and Ankara for SCISCI: Fix Detector To Not Flag Shivers 2, Betrayal at Krondar and Ankara for SCI

comment:4 by Sonnelon-Crucia, 2 years ago

I see, thank you very much for reply! I didnt realy had my hopes high, but decided to try. Looks like there is no emulator that could launch "Betrayal in Antara". It is a real pity, this game is my most favorite from old times.

comment:5 by sluicebox, 2 years ago

Owner: set to sluicebox
Resolution: invalid
Status: newclosed

Closing as invalid since this is a story of adding an unsupported game that has the same generic filenames as other SCI32 games, causing autodetector to suggest a different game. That the suggested game happened to be Shivers 2 confused the issue -- we deliberately have that as an entry with the ADGF_UNSUPPORTED flag set. (Work was started long ago to add support.) But even without the Shivers 2 detection entry, auto detector just would have suggested a different SCI32 game with the same generic filenames.

If bluegr wants to we can remove the Shivers 2 detection entry if it's indeed not helping anything.

Note: See TracTickets for help on using tickets.