Unknown game variant for sword1

[ner00]

Due to recent changes in the detection for this engine (maybe others), v2.7 is now unable to start some versions of this game. Among them is one French release of Broken Sword: Shadow of the Templars (Les Chevaliers de Baphomet) from the Adventure Hall of Fame collection. The existing entries in detection_tables.h are missing the first hash for swordres.rif, the existing french entry has a different hash, possibly from the original release of the same game.

Matched game IDs for the sword1 engine: sword1-demo-win

{"swordres.rif", 0, "665b7ed64c13013ec4a8bcd101a1e862", 59788},
{"compacts.clu", 0, "7128bc4e99701d99c22e5841051671d3", 200852},

[lotharsm]

Could you please check if this works properly now? We had some fixes in the detection entries a few days ago.

[ner00]

Hi.

No, it still doesn't work. I can see that the detection tables are slightly different, but especially the way they are reported to the user, but the entries I mentioned are still missing. This is what I get now:

Matched game IDs for the sword1 engine: sword1-demo-win

{"xn--clustersscripts.clu-2a08g", 0, "72b10193714e8c6e4daca51791c0db0c", 1088372},
{"xn--clustersswordres.rif-3a62h", 0, "665b7ed64c13013ec4a8bcd101a1e862", 59788},
{"xn--clusterstext.clu-za24f", 0, "76f93f5feecc8915435105478f3c6615", 3188750},
{"xn--smackshiintro.smk-0a88f", 0, "d602a28f5f5c583bf9870a23a94a9bc5", 13525168},

The 1st file is currently only present in the table for an Italian variant (Windows platform), the rest are PSX variants. The 2nd and 3rd files are not present in the table at all. The 4th file is the same as the current entries for the French version (Windows/Mac), but then the first 3 are a mismatch for the same language.

Cheers.

[lotharsm]

Hm, those file names look _way_ off. Is this a legitimate copy?

[ner00]

Yes, it's legitimate.

How do you mean the filenames look _way_ off? I was also surprised but brushed it off as being part of the _revamped_ detection table, and so I just ignored that it looked a bit weird.

For example:
_"xn--smackshiintro.smk-0a88f"_

• "xn--": Well, I have no clue where scummvm gets that from or what it could mean.
• "smackshiintro.smk": "smackshi" is the folder containing the highres Smack vídeo cutscenes. And "intro.smk" is an individual video cutscene file.
• "-0a88f": Also no clue what that is, seems some kind of CRC, hash, byte pattern, but certainly not part of the filename.

So yeah, that's how the current master is reporting the hashes now :)

[lotharsm]

Yes, with "way off" I mean the punycode encoding.

Punycode consists of the "xn--" prefix and a matching suffix, (that's the "-za..." part at the end of the filenames).

And that's very surprising, because no other version of the games use punycode encoded filenames. End what's even more surprising, it looks like the punycode encoding is not done properly, rendering the filenames in a wrong way...

[ner00]

Well, I really have no clue about that. Is there some thing user-environment-wise that could be causing that?

[ner00]

It doesn't seem to have this issue when using the command line --md5 detection. And this didn't happen at all with the daily build I used a few weeks ago.

[ner00]

This seems to start happening after the changes introduced in this commit: ​https://github.com/scummvm/scummvm/commit/032b9b46b96599f6f216fdb13308257070a36fa2

[criezy]

Thank you for the report.
I have now added this detection.

The main difference with the Windows French version detection we already had is that the text.clu file is quite a bit bigger. This file contains the text for all officially supported languages. However early releases of the game are known to be missing the Portuguese Brazilian text, and my guess if that your version is a more recent release that includes that text.

And I have also open a pull request for the unexpected punycode encoding issue: ​https://github.com/scummvm/scummvm/pull/4657