#1401 closed defect (fixed)
BS1: Cutscenes don't respond
| Reported by: | Kirben | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sword1 |
| Version: | Keywords: | ||
| Cc: | Game: | Broken Sword 1 |
Description
Latest ScummVM cvs version. English version of Broken Sword 1 Compiled under mingw with GCC 3.2.3 and running under Windows XP.
ScummVM doesn't respond to keyboard commands when cutscenes are playing, ie alt enter. If I switch to another program and back to ScummVM, it seems to lock up. The audio continues in background but display is no longer updated.
Shouldn't the delays for decodeFrame() in sword1/animation.cpp be going through delay() instead of system backend directly ?
Ticket imported from: #881112. Ticket imported from: bugs/1401.
Change History (6)
comment:1 by , 21 years ago
| Component: | → Engine: Sword1 |
|---|---|
| Game: | → Broken Sword 1 |
comment:2 by , 21 years ago
| Owner: | set to |
|---|
comment:3 by , 21 years ago
comment:4 by , 21 years ago
The patch I attached to bug #880484 has a minimal fix to this since it calls poll_event() as well as delay_msecs(), but that's just because I wanted to keep the patch minimal. (The delay() function is private.)
You're right that if all we do is call delay_msecs() ScummVM won't respond to standard events. In the SDL backend that includes the SDL_VIDEOEXPOSE event, which is probably why ScummVM appears to lock up. It doesn't realize that it has to redraw the game window.
Assigning to Ender, since he's the one doing cutscene work. I think.
comment:5 by , 21 years ago
| Owner: | removed |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:6 by , 15 years ago
| Owner: | set to |
|---|
The patch I attached to bug #880484 has a minimal fix to this since it calls poll_event() as well as delay_msecs(), but that's just because I wanted to keep the patch minimal. (The delay() function is private.)
You're right that if all we do is call delay_msecs() ScummVM won't respond to standard events. In the SDL backend that includes the SDL_VIDEOEXPOSE event, which is probably why ScummVM appears to lock up. It doesn't realize that it has to redraw the game window.
Assigning to Ender, since he's the one doing cutscene work. I think.