SCI: Phantasmagoria crashes when all saves are in chapter 7

[darkshoxx]

It appear that after creating 10 gamefiles of Phantasmagoria 1, launching a new game crashes and opens the debug mode.
The first time this happened, my PC crashed a few minutes afterwards, unsure if related or not. I was streaming at the time through OBS.
Not sure if relevant, added link to VOD just after game crash, before PC crash:
​https://www.twitch.tv/videos/1775169737?t=04h31m47s
Log and all savegame files related to Phantas are attached. When Savegames are removed, it appears to work.

[sluicebox]

Thanks for reporting this and providing all the saves files. I will take a look at them soon.

(Edited away my follow up questions because I read this wrong, I'll just get the answers from the attached files)

[sluicebox]

This is a bug in the original, and it happens when all 10 of your save slots are in the Chapter 7 chase and you click Start New Game. The slots are full, so the game is trying to make you select one to delete, but the programmer forgot that this screen doesn't display games that aren't in the chase, so it crashes because it's empty.

Instead, click "Watch Move (Review Chapter Seven)", select a save game, and click Delete to free up a slot. Start New Game will work again.

[darkshoxx]

ah fair enough, didn't expect that to be the intended behaviour. Now would there be any reason for scummVM to crash my PC... twice? Added another VOD link just in case
​https://www.twitch.tv/videos/1775679994?t=00h10m22s
Tbf my PC hasn't been the most stable recently, but it happened twice while running the game. It also keeps Lagging every now and again.
Also i don't see the message here anymore, but my ScummVM version I'm using is 2.6.0 (as opposed to the version 2.0.0 that comes with it on gog.
I sadly don't have another log file because it was overwritten by the next one.

If there's no reason for the PC crashes to be caused by the game or ScummVM, I guess this ticket can be closed ?

[sluicebox]

Oh, this is very much a bug, and I will try to fix it, it's just that this is a bug in the original game and you can workaround it by going to a different screen.

ScummVM should not be crashing your entire computer, and we can take a look at that, but it suggests a deeper instability. (We shouldn't be able to crash Windows even if we wanted to.) For something like that, including lagging under OBS, our Discord is probably a better place to troubleshoot. Also, I recommend using the recent 2.7.0 release instead, that's what everyone's first suggestion will be. The game/save files will all still be compatible.

[sluicebox]

Fixed in: ​https://github.com/scummvm/scummvm/commit/2f5b5b4e282e79ebea336407a5721641de184d8b

When starting a new game when all 10 slots are full, the game will now display all 10 saves when prompting to delete. This prevents the bug where the screen crashes because it's empty, and it also makes the screen easier to use since it's demanding that you free up a slot while hiding saves.

Years ago I fixed several bugs in the chapter 7 chase saves, and I remember being confused by this and wondering if it could be improved. It can!

Thanks again for reporting and including all of those save files; it took all of them to figure this out -- I wouldn't have guessed that *all 10* were in chapter 7! =)

This fix will appear in our next daily build. There's installers at ​https://www.scummvm.org/downloads/#daily and we also have zips at ​https://buildbot.scummvm.org/#/dailybuilds

[darkshoxx]

Cool! Thanks a lot! Yeah after a speedrun the game data stays but you can't load. I didn't know at that time that it was deletable in the reveiw menu. I guess this bug will really only pop up if someone speedruns it, thereby making more and more level 7 save files. But I'm glad you fixed it, thank you.
Concerning the crashes, I'll see if I can reproduce it somehow, and then go to the discord.
I'll also test it in the daily build!