AGI: Winnie the Pooh unable to parse wind sound (sound 10)

[dshell102]

--- Updated Description by sluicebox ---

The wind sound, sound 10, is not playing. AgiSound::createFromRawResource is rejecting it because its first two bytes are 00 9F and that doesn't match what it expects. This affects at least the DOS version. I have confirmed that these are the correct bytes for this sound.

--- Original Description ---

I only find 9 items every time. When the wind blows, it should allow you to keep playing with the items moved, but instead the program shuts down.

I try to play in dosbox but it only does 4 colors.

With scummvm, is there a way to prevent the program from closing?

Thank you.

[dshell102]

save game - only 9 items

[dshell102]

Is this something I need to do, an update made or just a note someone made?

Thank you!

[tag2015]

Hi, you don't need to do anything, I just changed the component/title so it's easier to find in the bugtracker.
Hopefully somebody who knows both the engine and the game can take a look :)

[sluicebox]

This was a segfault due to not testing for errors when attempting to parse an AGI sound. For some reason, the wind sound (sound 10) is failing to play. Our code is rejecting it because of the first two bytes. I don't know why, I don't know this game at all.

Crash is fixed in: ​https://github.com/scummvm/scummvm/commit/198e28bdd9b3097286a030dab6060f63e7bc1217

The sound still doesn't play, so I'm leaving this open, renaming it, and lowering the priority.

[sluicebox <22204938+sluicebox@…>]

In e4f8b6a4:

AGI: Fix AGIv1 sound detection

• Fixes Winnie the Pooh wind sounds, bug #14454
• Fixes Donald Duck's Playground sound 5
• Fixes various sounds in KQ2 and BC

The sound loading code attempted to detect AGIv1 sounds by the first
two bytes, but this dind't work beause AGIv1 sounds have no header.
Each AGIv1 game has at least one sound that failed this heuristic.

Now we use the interpreter version instead of attempting detection,
which is what the sound playback code in SoundGenPCJr does anyway.

[sluicebox]

Fixed in: e4f8b6a4567542bb3f123b903069475b65d35733

Wind sounds now work. Thanks for reporting this!