Opened 14 months ago
Closed 14 months ago
#14601 closed defect (fixed)
ACCESS: File not closed after exit (Guardians of Eden)
Reported by: | GandalfTheWhite80 | Owned by: | PushmePullyu |
---|---|---|---|
Priority: | normal | Component: | Engine: Access |
Version: | Keywords: | ||
Cc: | GandalfTheWhite80 | Game: | Amazon: Guardians of Eden |
Description (last modified by )
- Start "Amazon: Guardians of Eden"
- close the game after the intro with the "x"
- the "TDROM\GAME\ETEXT1.DAT" won't be closed / there is a file lock on this file until closing scummvm
- svummvm daily (2.8.0/Sep 3.2023)
- win64 (win10)
- Amazon: Guardians of Eden GOG Version
Change History (4)
comment:1 by , 14 months ago
Description: | modified (diff) |
---|---|
Summary: | ACCESS: File not closed after exit → ACCESS: File not closed after exit (Guardians of Eden) |
comment:2 by , 14 months ago
Description: | modified (diff) |
---|
comment:3 by , 14 months ago
comment:4 by , 14 months ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Th PR has been merged. Thanks!
Note:
See TracTickets
for help on using tickets.
Thanks for the report!
This seems to be a file handle leak caused by the following code:
in engines/access/amazon/amazon_logic.cpp:
in void CampScene::mWhileDoOpen():
The first call to loadEstablish() assigns a new Resource to Access::Resource *Access::AccessEngine::_establish. This resource holds a file handle for "ETEXT1.DAT".
The second call now reassigns to _establish, so the Resource it pointed to previously is lost, including the file handle.
PR with fix is here: https://github.com/scummvm/scummvm/pull/5310