TWINE: Multiple track issues

[Melechtna]

Most of the tracks work just fine, but, there are a few of note, in the adeline sequence, it wants track 31, track 31 is in place from the steam source, but it doesn't even attempt to play the mp3, where as all other tracks work fine for midi replacement.

Second is the credits, normally these should play track 08, if you're on the menu, it tries to access track 255 from midi_mi.hqr, which obviously doesn't exist. Then during the end game sequence, track 08 plays where it should, then cuts off entirely once the credits roll.

Finally there's twinsens dream sequence in the beginning, instead of playing track 1, like with track 31, it just decides to say screw it and skips checking entirely.

There may be more, but I was mainly skipping through using debug to figure out where the tracks SHOULD go, and since concluded that besides the first 9 tracks, which I took from the symphonic suite remaster, the rest are all off by 1, which would be a nice bit of information to have for the track substitution on the TwinE wiki page. This seems to be true of all 2 point 21 ports of the game.

[Melechtna]

User picked target 'lba-cd' (engine ID 'twine', game ID 'lba')...

Looking for a plugin supporting this target... Little Big Adventure

Running Little Big Adventure (Relentless: Twinsen's Adventure - CD Original North America Version/DOS/English)
RELENT.EXE: c1a887e38283d43f271249ad9f2a73ef, 258513 bytes.
Based on TwinEngine v0.2.2
(c) 2002 The TwinEngine team.
(c) 2020-2022 The ScummVM team.
Refer to the credits for further details.
The original Little Big Adventure game is:
(c) 1994 by Adeline Software International, All Rights Reserved.
Use midi_mi.hqr for midi
preload 100 trajectories
preload 118 sprites
preload 516 animations
preload 243 samples
preload 28 inventory items
Loaded 14 text banks
enable keymap cutsceneKeyMap
Play midi file for index 31
Play fla: dragon3
enable keymap uiKeyMap
Play cd music track 9
enable keymap mainKeyMap
WARNING: No such track 255!
WARNING: HQR: Invalid entry index!
WARNING: HQR: failed to get entry for index 255 from file: midi_mi.hqr!
Could not find midi file for index 255
WARNING: Failed to play track 255!
Failed to initialize body -1 for actor 24
enable keymap uiKeyMap
Play fla: dragon3
Play fla: bateau
Play midi file for index 31
enable keymap mainKeyMap
WARNING: No such track 255!
WARNING: HQR: Invalid entry index!
WARNING: HQR: failed to get entry for index 255 from file: midi_mi.hqr!
Could not find midi file for index 255
WARNING: Failed to play track 255!
Failed to initialize body -1 for actor 24
enable keymap uiKeyMap
Play fla: dragon3
Play fla: bateau
Play midi file for index 31
enable keymap mainKeyMap
WARNING: No such track 255!
WARNING: HQR: Invalid entry index!
WARNING: HQR: failed to get entry for index 255 from file: midi_mi.hqr!
Could not find midi file for index 255
WARNING: Failed to play track 255!
enable keymap uiKeyMap
Play fla: dragon3
Play midi file for index 1
Play fla: introd

A log of where all 3 errors occur

[vvs-]

Replying to Melechtna:

Most of the tracks work just fine, but, there are a few of note, in the adeline sequence, it wants track 31, track 31 is in place from the steam source, but it doesn't even attempt to play the mp3, where as all other tracks work fine for midi replacement.

There are only 9 audio tracks on CD, so what mp3 track 31 could be there on Steam? Looks like you are talking about MIDI tracks here.

[Melechtna]

Replying to vvs-:

Replying to Melechtna:

Most of the tracks work just fine, but, there are a few of note, in the adeline sequence, it wants track 31, track 31 is in place from the steam source, but it doesn't even attempt to play the mp3, where as all other tracks work fine for midi replacement.

There are only 9 audio tracks on CD, so what mp3 track 31 could be there on Steam? Looks like you are talking about MIDI tracks here.

It's best not to skim these things and/or make assumptions

[Melechtna]

​https://github.com/scummvm/scummvm/commit/ddb0420ef63221a45202139378744f27c259f0ca

This commit doesn't seem to fix the Adeline jingle for versions other than GoG. I can't test if this does work as I don't have the GoG version, but given I can swap out the midis with the steam versions tracs as long as it's track numbered correctly, I don't see why this should be an exception.

I have however built ScummVM with the latest commit to the TwinE engine up to here
​https://github.com/scummvm/scummvm/commit/39d60856aaca25a2a609b7f15727e0f6aced592b

And these errors are still present.

[vvs-]

Replying to Melechtna:

It's best not to skim these things and/or make assumptions

Looking at the sources TwinE indeed doesn't distinguish between CD and MIDI. But this is probably even not documented anywhere and I never heard before that one can replace MIDI tracks too.

In the original game CD track numbers were even shifted by one relative to MIDI. But this might be caused by the different origin count? And there is explicit check that it should be not greater than nine.

GoG version has almost no difference with retail CD version. Adeline logo sound is playing there only if an external MIDI synthesizer was specified but no sound otherwise. There was a bug report about this here already.

[tag2015]

Replying to vvs-:

GoG version has almost no difference with retail CD version. Adeline logo sound is playing there only if an external MIDI synthesizer was specified but no sound otherwise. There was a bug report about this here already.

It's not the same, at least my GoG version ("Twinsen's Little Big Adventure Classic v3.2.3.2") installed with galaxy, has a Common/Midi dir which contains the 33 tracks converted to .mp3 and no .mid files at all (loose or in midi.hqr). So that's why the engine plays these tracks as if they were cd tracks.
This only works on scummvm 2.8.0, however. Version 2.7.1 ignores the converted tracks.

[Melechtna]

Replying to tag2015:

Replying to vvs-:

GoG version has almost no difference with retail CD version. Adeline logo sound is playing there only if an external MIDI synthesizer was specified but no sound otherwise. There was a bug report about this here already.

It's not the same, at least my GoG version ("Twinsen's Little Big Adventure Classic v3.2.3.2") installed with galaxy, has a Common/Midi dir which contains the 33 tracks converted to .mp3 and no .mid files at all (loose or in midi.hqr). So that's why the engine plays these tracks as if they were cd tracks.
This only works on scummvm 2.8.0, however. Version 2.7.1 ignores the converted tracks.

You're half right here, I'm using 2.7.1, and it will actually choose the tracks over the midis in MOST cases, except these three.

[tag2015]

Replying to Melechtna:

You're half right here, I'm using 2.7.1, and it will actually choose the tracks over the midis in MOST cases, except these three.

Interesting, it doesn't work with my GOG version. This is at the beginning of a new game:

midi disabled - skip playing 18
WARNING: Failed to play track 18!

[Melechtna]

Replying to tag2015:

Replying to Melechtna:

You're half right here, I'm using 2.7.1, and it will actually choose the tracks over the midis in MOST cases, except these three.

Interesting, it doesn't work with my GOG version. This is at the beginning of a new game:

midi disabled - skip playing 18

So, it's weird, in order for me to get the tracks working, I had to put them in the root directory, and make it "track18.mp3", next to the other 9 tracks, in order for it to pick it up, it doesn't seem to pick them up if they're in the common/midi directory.

Play cd music track 9
enable keymap mainKeyMap
WARNING: Failed to get entity body for body idx 255!
Failed to initialize body 255 for actor 9
WARNING: Failed to get entity body for body idx 255!
Failed to initialize body 255 for actor 10
WARNING: Failed to get entity body for body idx 255!
Failed to initialize body 255 for actor 11
WARNING: Failed to get entity body for body idx 255!
Failed to initialize body 255 for actor 12
Skipping ID3 TAG (2117 bytes)
Play cd music track 18

Here's mind doing it, and it's the DOS version, neither GoG nor Steam, but a hybrid of the DOS and Steam mp3s

WARNING: Failed to play track 18!
}}}

[tag2015]

Replying to Melechtna:

Here's mine doing it, and it's the DOS version, neither GoG nor Steam, but a hybrid of the DOS Game, the remasterd flacs, and Steam mp3s

Mix'n'matching the files is likely to cause problems, the engines are tested using the original versions or the digital releases.
Anyway I'm not the twine engine developer so I'd rather let him answer

[Melechtna]

Replying to tag2015:

Replying to Melechtna:

Here's mine doing it, and it's the DOS version, neither GoG nor Steam, but a hybrid of the DOS Game, the remasterd flacs, and Steam mp3s

Mix'n'matching the files is likely to cause problems, the engines are tested using the original versions or the digital releases.
Anyway I'm not the twine engine developer so I'd rather let him answer

Okay? Except you've literally pointed out an issue I too experienced, where neither the GoG nor Steam release picks up on its midi replacements, meanwhile, hybridizing, as I've just demonstrated, does pickup the extra tracks, with 3 exceptions, as I've plainly outlined in the initial issue. Honestly I rather like this hybridized approach (besides the temple of bu being completely broken), as this grants me a "best of all worlds" version of the game. I get what was there in the beginning, superior music without mucking with the midi synth to get it all to sound right, and the original starting animation.

This is neither here nor there however, as there are clear issues with the tracks not being picked up correctly, even when they're detected to begin with, and the documentation of how this is currently, or supposed to work, is completely lacking, as I stitched this together through guess work and watching the console.

[vvs-]

Replying to tag2015:

It's not the same, at least my GoG version ("Twinsen's Little Big Adventure Classic v3.2.3.2") installed with galaxy, has a Common/Midi dir which contains the 33 tracks converted to .mp3 and no .mid files at all (loose or in midi.hqr). So that's why the engine plays these tracks as if they were cd tracks.

Heh, but it was :) I'm using either GoG 2.1.0.22 or CD retail for testing. I'm not using their Galaxy client and downloading 400 MB file for every update is not an option. But after you mentioned it I might take a look for what's new in there :)

[mgerhardy]

I hope that 69c5c3a43c4444d82b0982fb28061914d0f03aed fixes the issue

[mgerhardy]

Looks like this one produced a regression in https://bugs.scummvm.org/ticket/15410. Maybe the offset for the tracks should not be generally applied - but we have to identify the exact release(s) where it should get added.