Opened 11 months ago

Closed 5 days ago

Last modified 4 days ago

#14793 closed defect (fixed)

AUDIO: Intro music of DOTT doesn't work anymore on clean config and LINUX+SDL

Reported by: mikrosk Owned by: elasota
Priority: blocker Component: Audio
Version: Keywords:
Cc: Game: Day of the Tentacle

Description

Sound effects work but the iconic music is gone.

The commit which broke it was https://github.com/scummvm/scummvm/commit/8bb2afd2.

Tested on Linux + SDL, present in both latest master and 2.8.0.

Change History (18)

comment:1 by mikrosk, 11 months ago

I tested it also with removed scummvm.ini, no change.

comment:3 by elasota, 11 months ago

Does it work if you disable General MIDI in the settings?

comment:4 by mikrosk, 11 months ago

You mean MIDI -> GM device: Don't use General MIDI music? Yes, after changing it to this value from "Use first available" it works.

comment:5 by elasota, 11 months ago

What options are listed under the "GM device" drop-down?

comment:6 by mikrosk, 10 months ago

Don't use General MIDI music
Use first available device
Midi Through [ALSA]
SEQ
Sndio
FluidSynth
TIMidity

comment:7 by AndywinXp, 10 months ago

Component: Engine: SCUMMAudio
Summary: DOTT: Intro music doesn't work anymoreAUDIO: Intro music of DOTT doesn't work anymore on clean config and LINUX+SDL

comment:8 by rsn8887, 9 months ago

A similar problem happens on Vita/Switch, see here: https://forums.scummvm.org/viewtopic.php?t=17022

On those platforms I fixed it for the future by defaulting GM Device Config entry to "null".

comment:9 by mikrosk, 4 months ago

Just for the sake of completeness, this has been fixed (worked around with the "null" driver) in the 2.8 branch (unfortunately after the 2.8.1 release): https://github.com/scummvm/scummvm/commit/6efbd4f5.

Maybe it could go to master if a proper fix is not possible in a near future?

comment:10 by dwatteau, 4 months ago

Priority: normalblocker

Good point mikrosk, I’m making this a blocker for the next 2.9 release, so that we won’t miss this. I’ve asked sev about doing so.

comment:11 by bluegr, 7 days ago

Some days ago, this PR has been merged:
https://github.com/scummvm/scummvm/pull/5622

Does that fix the issue?

comment:12 by mikrosk, 6 days ago

Indeed, audio now works as expected (verified on a clean setup in Linux and on Atari).

Perhaps someone with Vita/Switch should give the final blessing (with the reverted "null" gm_device in the backends).

comment:13 by sev-, 5 days ago

Owner: set to elasota
Resolution: fixed
Status: newclosed

Okay, closing as fixed.

comment:14 by tag2015, 5 days ago

Can confirm that Vita works fine too

comment:15 by mikrosk, 5 days ago

@tag2015: did you test this with https://github.com/scummvm/scummvm/commit/fcddbb0fc1d3eb88cbb1dbe4f75c6c2e317f0f67 / https://github.com/scummvm/scummvm/commit/5fe3c560b62b5476f722214ac85116f961476b67 reverted? I don't see the revert commit in master and naturally, with those in place you can't really test the effect of ​https://github.com/scummvm/scummvm/pull/5622.

comment:16 by tag2015, 5 days ago

Ah, no I simply tested latest buildbot for Vita (with clean config).
I haven't really followed this bug, I just noticed your comment about testing on Vita so I gave it a spin (haven't used it for some time...)

comment:17 by mikrosk, 5 days ago

I have created a PR for that purpose: https://github.com/scummvm/scummvm/pull/6226.

comment:18 by mikrosk, 4 days ago

@tag2015: the PR was merged yesterday, please retest in a clean setup (without the ini file)

Note: See TracTickets for help on using tickets.