Opened 10 months ago

Closed 3 days ago

#14857 closed defect (fixed)

GOB: Version from main menu shows nothing for GOG version

Reported by: antoniou79 Owned by: bluegr
Priority: low Component: Engine: Gob
Version: Keywords:
Cc: Game: Goblins 3

Description (last modified by antoniou79)

This is tested with Goblins 3, GOG version, ScummVM 2.8.0 and 2.9.0git current master HEAD.

When selecting Version from the in-game menu (top of the screen, select the "diskette" icon and then "VERSION"), the game shows seemingly badly initialized text that makes little sense.

This is because the GOG version is missing the "VERSION" file, which, as far as I can tell, has to be read in order to correctly display the VERSION info for the game.

Our wiki for the game makes no mention of the VERSION file either, in the required data files for the game. https://wiki.scummvm.org/index.php/Goblins_3

Since the game is detected as "Goblins Quest 3 (CD v1.02/DOS/English)" by ScummVM detection, it could be possible to implement a fallback for this case and display a version text based on the detection findings.

I am attaching screenshot of how it looks without VERSION (GOG version), and how it should look properly.

Attachments (2)

scummvm-gob3-cd-00004.png (82.4 KB ) - added by antoniou79 10 months ago.
scummvm-gob3-cd-proper.png (77.9 KB ) - added by antoniou79 10 months ago.

Download all attachments as: .zip

Change History (6)

by antoniou79, 10 months ago

Attachment: scummvm-gob3-cd-00004.png added

by antoniou79, 10 months ago

Attachment: scummvm-gob3-cd-proper.png added

comment:1 by antoniou79, 10 months ago

Description: modified (diff)

comment:2 by Filippos Karapetis <bluegr@…>, 3 days ago

In 4760b533:

GOB: Add version fallback from our detection tables - bug #14857

If the VERSION file is missing, we now provide a fallback. Version
files exist in gob3 and inca2, so this should cover all known cases

comment:3 by Filippos Karapetis <bluegr@…>, 3 days ago

In d4b08b03:

GOB: Add version fallback from our detection tables - bug #14857

If the VERSION file is missing, we now provide a fallback. Version
files exist in gob3 and inca2, so this should cover all known cases

comment:4 by bluegr, 3 days ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.