M4: Orion Burger: Demo crashes when using the gun on the ice cube in any floor other than the bottom floor

[antoniou79]

This is on Windows 10, with ScummVM 2.9.0git, build from master HEAD in release mode with msys2/mingw-w64.

When using the gun from the inventory on the ice cube (also in the inventory) in any floor of the gerbil cage other than the bottom floor, ScummVM crashes with a message on the debugger.

Depending on the floor the message is slightly different:

• On the top floor it says: ERROR: get_file - getting 604melts!
• On the middle floor it says: ERROR: get_file - getting 603melts!

I've tried a naive way of fixing this, by disabling the shadows for Wilbur (clearing the WITH_SHADOW bit of the flags) for these specific animations (so the engine won't try to get the animations with an "s" suffix), and that works, but it's not what the original game is doing.

When playing the demo with DosBox, Wilbur does have a shadow in both of these animations (top floor and middle floor).

I am unsure if this is also an issue for the full game.

[dreammaster]

I checked, and no it's not an issue with the full game. It has a 604melts. Unfortunately, I've had trouble trying to do a disassembly of the demo executable to do a comparison with that of the full game.

For now, like you, I'm just going to do a conditional check not to pass WITH_SHADOWS to the break method call, so at least it won't crash. The only downside, apart from the shadow, is that Wilbur briefly disappears at the end of it on all three flooors, but only in the demo.