Opened 6 months ago

Closed 5 months ago

#15142 closed defect (fixed)

SCI: Betrayed Alliance v1.3.2: Different color cursor

Reported by: dfsgand Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords: cursor graphics
Cc: Game: SCI Fanmade

Description

ScummVM version: ScummVM 2.9.0git4897-g054e28f118a on Linux (amd64, Debian 11.9)

Game: Betrayed Alliance v1.3.2, ​https://github.com/Slattstudio/BetrayedAllianceBook1/releases/tag/release-v1.3.2

The mouse cursor is white in DOSBox but grey in ScummVM, see attached screenshots.

Attachments (2)

betrayed_alliance_cursor.png (20.0 KB ) - added by dfsgand 6 months ago.
DOSBox screenshot
betrayed_alliance_cursor_scummvm.png (68.3 KB ) - added by dfsgand 6 months ago.
ScummVM screenshot (grey cursor)

Download all attachments as: .zip

Change History (7)

by dfsgand, 6 months ago

DOSBox screenshot

by dfsgand, 6 months ago

ScummVM screenshot (grey cursor)

comment:1 by sluicebox, 6 months ago

Priority: lownormal

Thanks for reporting this.

This looks like a discrepancy in GfxCursor::kernelSetShape. It is using gray pixels when both cursor mask bits are set.

According to the TODO comment, this color selection hasn't been reverse engineered yet. There are also two game-specific hacks for color selection.

Related: #5971, #5983

comment:2 by dfsgand, 6 months ago

The github page mentions that the game was developed using SCI Studio, and the SCI Wiki says the source is available for this tool: http://sciwiki.sierrahelp.com/index.php/SCI_Studio https://web.archive.org/web/20061113153443/http://www.bripro.com/scistudio/download.php. Maybe the source would contain some clues to how the color selection works, since it presumably works properly there.

comment:3 by sluicebox, 6 months ago

I have a fix pending; we've been drawing SCI0 cursors wrong. You can see it in other Sierra games, but it's subtle. There are other issues in this cursor code, so I'm going to try to get them all sorted before making any changes.

comment:4 by sluicebox <22204938+sluicebox@…>, 5 months ago

In 61323e8d:

SCI: Use correct SCI0/SCI1 cursor colors

Fixes bugs #15142, #5983, #5971

comment:5 by sluicebox, 5 months ago

Owner: set to sluicebox
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.