amiga render mode for dos ega version of indy 3 an the last crusade last crusade possible?

[gabberhead]

the ega dos version of indy 3, has the same problem like maniac mansion and zak macracken have. the skin color is darker and dont look as goog as the amiga versions. i think the color of the whole game is also darker as in the amiga version. but maniac mansion and zac macracken have the option to use the amiga render mode on the dos ega version. now my question, is it possible to add this feature to scummvm, to have the possibilty also using the amiga renderer on indy 3 ega dos version? because now there are only 2 options which can be used. cga and vga. ega isnt even available in the render options. and vga i think, is wrong for the ega version. because, if u select vga, it dont change anything.

[dwatteau]

ega isnt even available in the render options. and vga i think, is wrong for the ega version

Strange, here, I see EGA and CGA for my French DOS EGA release of Indy3. Maybe try removing/adding the game again from the general menu, so that the detection code is triggered again.

now my question, is it possible to add this feature to scummvm, to have the possibilty also using the amiga renderer on indy 3 ega dos version?

I think this used to be possible a few releases ago, i.e. almost every renderer combination could be tried, even the completely unrealistic ones. But, if my memory serves me well, people would complain about the very strange results (or crashes?) they would get, so now, the only "unofficial" rendering changes we allow are for Maniac/Zak V2, i.e. the popular "avoid the sunburn effect" Amiga setting.

This was the discussion back then:
​https://github.com/scummvm/scummvm/pull/4273

Anyway, yes, we could allow it for Indy3 EGA if it makes sense, too. I don't know if it's stable, though.

Attached is the diff allowing it (just for internal reference), and a couple of screenshots of what it would change, if one enables the Amiga rendering mode for it.

Is this was you expect? We'd still need to make sure that the game is playable with this setting.

and what about EGA Loom and EGA Monkey1, then? We may need to collectively think a bit more about this.

[dwatteau]

WIP diff for reference

[dwatteau]

EGA DOS mode (1)

[dwatteau]

forced Amiga renderer (1)

[dwatteau]

EGA DOS mode (2)

[dwatteau]

forced Amiga renderer (2)

[gabberhead]

thats what i mean :)
but why is that, that the dos version have darker colors and more red skin colour? zak macracken and maniac mansion have also this "problem". but is it a problem? or is it the right behavior for each platform? if not, which one of that is then more accurate?
monkey island and loom i didnt test, but now i have. and yes, the "sunburn" effect is also on the dos ega versions compared to the amiga.

ps: i added indy 3 ega again to scummvm, but the same problem here, no ega. only cga and vga. but i am using a modified german version of the game, which i made. i made a complete uncensored amiga and dos ega version of the game. but i think, u know this already :) and modified a little bit, the fan uncut version of the vga and fm towns version. fmtowns more than a little bit

[dwatteau]

Please keep the ticket titles the way we rename them. We have a naming scheme for them, for easier tracking (e.g.: prefix it with the engine name), and tickets not following this have higher chances of being missed. Thank you :)

Replying to gabberhead:

thats what i mean :)

Alright, thanks, I'll submit a PR for Indy3 EGA alone, and see where the discussion goes about the other EGA SCUMM titles.

monkey island and loom i didnt test, but now i have. and yes, the "sunburn" effect is also on the dos ega versions compared to the amiga.

Thanks for this quick test.

but why is that, that the dos version have darker colors and more red skin colour? zak macracken and maniac mansion have also this "problem". but is it a problem? or is it the right behavior for each platform? if not, which one of that is then more accurate?

PCGamingWiki has a possible explanation, I don't know how true it is:

​https://www.pcgamingwiki.com/wiki/Maniac_Mansion#Higher_quality_graphics_in_V2_.22enhanced.22_version_.28ScummVM.29

The folks on some forums such as VOGONS or Mixnmojo may have more to say about this. Or come over our #offtopic channel in our Discord server, for such questions.

Personally, I just see this as a "personal preference / nothing is right, nothing is wrong" thing :)

ps: i added indy 3 ega again to scummvm, but the same problem here, no ega. only cga and vga. but i am using a modified german version of the game, which i made. i made a complete uncensored amiga and dos ega version of the game. but i think, u know this already :) and modified a little bit, the fan uncut version of the vga and fm towns version. fmtowns more than a little bit

Ah yes, that's likely because you run your own modified version, which isn't in our detection tables. When a game variant isn't registered in our detection tables, we have a fallback mechanism, but it sometimes gets a few things wrong (I had similar problems when doing my own translation of the floppy release of Monkey1 VGA).

[dwatteau]

In c282769f:

SCUMM: Allow using the Amiga render for Indy3 EGA (Trac#15227)

It makes sense to allow using the Amiga render option for Indy3 EGA, as it's
already quite popular to do so for Maniac Mansion and Zak in order to avoid
the so-called "sunburnt effect", and also for personal palette preferences.

Then, the question is also open for Loom EGA and Monkey1 EGA, maybe?

See similar commit 4586d2fc9df145492ab9e62f7d47c03b8f271944 for V2 games.

[dwatteau]

This should be fixed in the current daily builds.

Thanks for reporting this. As for the other EGA titles where this setting isn't enabled yet, it's in my own todo-list to revisit this subject later.